From f8d4aa5c1cbf53a46293df6b542610f961194246 Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Wed, 22 Jul 2020 23:16:55 +0200 Subject: [PATCH 1/2] python.pkgs.fontforge: disable with Python 2 Since the latest update, fontforge no longer supports building with Python 2. Let's prevent failing builds. (cherry picked from commit ce55b09ad5d194368f71b0c2b92bffda794076fc) --- pkgs/top-level/python-packages.nix | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix index f67d9f084403..134f6197ae6c 100644 --- a/pkgs/top-level/python-packages.nix +++ b/pkgs/top-level/python-packages.nix @@ -3605,14 +3605,10 @@ in { folium = callPackage ../development/python-modules/folium { }; - fontforge = (toPythonModule (pkgs.fontforge.override { + fontforge = disabledIf (!isPy3k) (toPythonModule (pkgs.fontforge.override { withPython = true; inherit python; - })).overrideAttrs (old: { - meta = old.meta // { - broken = isPy38; - }; - }); + })); fonttools = callPackage ../development/python-modules/fonttools { }; From d6f46d2a91b77d46abcbcc74861ff311d9df9741 Mon Sep 17 00:00:00 2001 From: Justin Humm Date: Sun, 4 Oct 2020 15:45:52 +0200 Subject: [PATCH 2/2] monoid: 2016-07-21 -> 2018-06-03 Also applied a patch, so we can build with python3Packages.fontforge, as fontforge doesn't have python2 bindings anymore. --- pkgs/data/fonts/monoid/default.nix | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/pkgs/data/fonts/monoid/default.nix b/pkgs/data/fonts/monoid/default.nix index 22714170fa4b..a4c6449f9179 100644 --- a/pkgs/data/fonts/monoid/default.nix +++ b/pkgs/data/fonts/monoid/default.nix @@ -1,19 +1,25 @@ -{ stdenv, fetchFromGitHub, python2 }: -# Python 3 support requires https://github.com/larsenwork/monoid/pull/233 to be merged +{ stdenv, fetchFromGitHub, fetchpatch, python3 }: stdenv.mkDerivation { pname = "monoid"; - version = "2016-07-21"; + version = "2018-06-03"; src = fetchFromGitHub { owner = "larsenwork"; repo = "monoid"; - rev = "e9d77ec18c337dc78ceae787a673328615f0b120"; - sha256 = "07h5q6cn6jjpmxp9vyag1bxx481waz344sr2kfs7d37bba8yjydj"; + rev = "a331c7c5f402c449f623e0d0895bd2fd8dc30ccf"; + sha256 = "sha256-RV6lxv5CjywTMcuPMj6rdjLKrap7zLJ7niaNeF//U1Y="; }; + patches = [ + (fetchpatch { + url = "https://github.com/larsenwork/monoid/pull/233/commits/f84f2ed61301ee84dadd16351314394f22ebed2f.patch"; + sha256 = "sha256-CxfFHlR7TB64pvrfzVfUDkPwuRO2UdGOhXwW98c+oQU="; + }) + ]; + nativeBuildInputs = [ - (python2.withPackages (pp: with pp; [ + (python3.withPackages (pp: with pp; [ fontforge ])) ];