From a3c24cd214fea98863b733343c7ee8b21740fd96 Mon Sep 17 00:00:00 2001 From: Stefan Frijters Date: Thu, 13 Aug 2026 23:09:40 +0200 Subject: [PATCH 1/2] git: enable strictDeps --- pkgs/by-name/gi/git/package.nix | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/by-name/gi/git/package.nix b/pkgs/by-name/gi/git/package.nix index 3aa66809b005..98938fd81afb 100644 --- a/pkgs/by-name/gi/git/package.nix +++ b/pkgs/by-name/gi/git/package.nix @@ -213,6 +213,8 @@ stdenv.mkDerivation (finalAttrs: { buildPackages.stdenv.cc ]; + strictDeps = true; + env = { # required to support pthread_cancel() NIX_LDFLAGS = From c0c3749ea6d3f7597613b6428fddffad1c30cd54 Mon Sep 17 00:00:00 2001 From: Stefan Frijters Date: Fri, 14 Aug 2026 17:26:31 +0200 Subject: [PATCH 2/2] git: remove uses of *FlagsArray Since structuredAttrs are enabled, the *Flags variables already are arrays. --- pkgs/by-name/gi/git/package.nix | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/gi/git/package.nix b/pkgs/by-name/gi/git/package.nix index 98938fd81afb..f20fdd8eaf3e 100644 --- a/pkgs/by-name/gi/git/package.nix +++ b/pkgs/by-name/gi/git/package.nix @@ -236,7 +236,7 @@ stdenv.mkDerivation (finalAttrs: { ]; preBuild = '' - makeFlagsArray+=( perllibdir=$out/$(perl -MConfig -wle 'print substr $Config{installsitelib}, 1 + length $Config{siteprefixexp}') ) + makeFlags+=( perllibdir=$out/$(perl -MConfig -wle 'print substr $Config{installsitelib}, 1 + length $Config{siteprefixexp}') ) ''; makeFlags = [ @@ -282,7 +282,7 @@ stdenv.mkDerivation (finalAttrs: { ''${enableParallelBuilding:+-j''${NIX_BUILD_CORES}} SHELL="$SHELL" ) - concatTo flagsArray makeFlags makeFlagsArray buildFlags buildFlagsArray + concatTo flagsArray makeFlags buildFlags echoCmd 'build flags' "''${flagsArray[@]}" '' + lib.optionalString withManual '' @@ -343,7 +343,7 @@ stdenv.mkDerivation (finalAttrs: { ''${enableParallelInstalling:+-j''${NIX_BUILD_CORES}} SHELL="$SHELL" ) - concatTo flagsArray makeFlags makeFlagsArray installFlags installFlagsArray + concatTo flagsArray makeFlags installFlags echoCmd 'install flags' "''${flagsArray[@]}" # Install git-subtree. @@ -486,7 +486,7 @@ stdenv.mkDerivation (finalAttrs: { installCheckTarget = "test"; - # see also installCheckFlagsArray + # see also installCheckFlags in preInstallCheck installCheckFlags = [ "DEFAULT_TEST_TARGET=prove" "PERL_PATH=${buildPackages.perl}/bin/perl" @@ -510,7 +510,7 @@ stdenv.mkDerivation (finalAttrs: { NIX_BUILD_CORES=32 fi - installCheckFlagsArray+=( + installCheckFlags+=( GIT_PROVE_OPTS="--jobs $NIX_BUILD_CORES --failures --state=failed,save" GIT_TEST_INSTALLED=$out/bin ${lib.optionalString (!svnSupport) "NO_SVN_TESTS=y"}