diff --git a/pkgs/development/python-modules/icoextract/default.nix b/pkgs/by-name/ic/icoextract/package.nix similarity index 50% rename from pkgs/development/python-modules/icoextract/default.nix rename to pkgs/by-name/ic/icoextract/package.nix index e9ef6393f22f..2cb81016e56e 100644 --- a/pkgs/development/python-modules/icoextract/default.nix +++ b/pkgs/by-name/ic/icoextract/package.nix @@ -1,29 +1,24 @@ { lib, - buildPythonPackage, - fetchPypi, - pefile, - pillow, - pythonOlder, - setuptools, + python3Packages, + fetchFromGitHub, }: -buildPythonPackage rec { +python3Packages.buildPythonApplication rec { pname = "icoextract"; version = "0.1.5"; pyproject = true; - disabled = pythonOlder "3.8"; - - src = fetchPypi { - inherit pname version; - extension = "tar.gz"; - hash = "sha256-/UxnWNyRNtwI4Rxx97i5QyjeMrUr5Sq+TfLTmU0xWyc="; + src = fetchFromGitHub { + owner = "jlu5"; + repo = "icoextract"; + rev = version; + hash = "sha256-McVG8966NCEpzc9biawLvUgbQUtterkIud/9GwOeltI="; }; - build-system = [ setuptools ]; + build-system = with python3Packages; [ setuptools ]; - dependencies = [ + dependencies = with python3Packages; [ pefile pillow ]; @@ -34,8 +29,10 @@ buildPythonPackage rec { pythonImportsCheck = [ "icoextract" ]; postInstall = '' - mkdir -p $out/share/thumbnailers - substituteAll ${./exe-thumbnailer.thumbnailer} $out/share/thumbnailers/exe-thumbnailer.thumbnailer + substituteInPlace exe-thumbnailer.thumbnailer \ + --replace Exec=exe-thumbnailer Exec=$out/bin/exe-thumbnailer + + install -Dm644 exe-thumbnailer.thumbnailer $out/share/thumbnailers ''; meta = with lib; { @@ -47,5 +44,6 @@ buildPythonPackage rec { bryanasdev000 donovanglover ]; + mainProgram = "icoextract"; }; } diff --git a/pkgs/development/python-modules/icoextract/exe-thumbnailer.thumbnailer b/pkgs/development/python-modules/icoextract/exe-thumbnailer.thumbnailer deleted file mode 100644 index c275ac919b6b..000000000000 --- a/pkgs/development/python-modules/icoextract/exe-thumbnailer.thumbnailer +++ /dev/null @@ -1,3 +0,0 @@ -[Thumbnailer Entry] -Exec=@out@/bin/exe-thumbnailer -v -s %s %i %o -MimeType=application/x-ms-dos-executable;application/x-dosexec;application/x-msdownload diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix index ad6e5882672b..b070a357c149 100644 --- a/pkgs/top-level/python-packages.nix +++ b/pkgs/top-level/python-packages.nix @@ -5757,7 +5757,9 @@ self: super: with self; { idasen = callPackage ../development/python-modules/idasen { }; - icoextract = callPackage ../development/python-modules/icoextract { }; + icoextract = toPythonModule (pkgs.icoextract.override { + python3Packages = self; + }); icontract = callPackage ../development/python-modules/icontract { };