From 47342693cedbc04330d2b75fa1a4b251f225776c Mon Sep 17 00:00:00 2001 From: Sergei Trofimovich Date: Tue, 29 Sep 2026 22:03:44 +0100 Subject: [PATCH] liquidwar: drop `-Werror` (gcc-16 fix) Without the change `liquidwar` build fails on `master` as https://hydra.nixos.org/build/347153247: ``` p2p-node.c:912:7: error: variable 'send_i' set but not used [-Werror=unused-but-set-variable=] 912 | int send_i = 0; | ^~~~~~ cc1: all warnings being treated as errors ``` --- pkgs/by-name/li/liquidwar/package.nix | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/pkgs/by-name/li/liquidwar/package.nix b/pkgs/by-name/li/liquidwar/package.nix index 35761a6e8d8d..51fe6b6de60a 100644 --- a/pkgs/by-name/li/liquidwar/package.nix +++ b/pkgs/by-name/li/liquidwar/package.nix @@ -90,21 +90,13 @@ stdenv.mkDerivation (finalAttrs: { hardeningDisable = [ "format" ]; - env.NIX_CFLAGS_COMPILE = toString ( - lib.optionals (stdenv.cc.isGNU && lib.versionAtLeast stdenv.cc.version "12") [ - # Needed with GCC 12 but problematic with some old GCCs - "-Wno-error=address" - "-Wno-error=use-after-free" - "-std=gnu17" - # Fix build w/ glibc-2.44 - "-Wno-error=discarded-qualifiers" - ] - ++ [ - "-Wno-error=deprecated-declarations" - # Avoid GL_GLEXT_VERSION double definition - " -DNO_SDL_GLEXT" - ] - ); + env.NIX_CFLAGS_COMPILE = toString [ + # gcc-12 and above generate many benign warnings + "-Wno-error" + "-std=gnu17" + # Avoid GL_GLEXT_VERSION double definition + "-DNO_SDL_GLEXT" + ]; # To avoid problems finding SDL_types.h. configureFlags = [ "CFLAGS=-I${lib.getDev SDL}/include/SDL" ];