From 2d5a96dca7838acda97c6286c68886f899230622 Mon Sep 17 00:00:00 2001 From: Dmitry Bogatov Date: Sat, 21 Mar 2026 06:00:00 -0400 Subject: [PATCH] rc: Simplify build system hack to generate "VERSION" macro Upstream uses complicated rule in Makefile that depends on .git/index to generate version.h. Instead of changing the rule, drop version.h from the dependency graph and generate it in post-patch phase. --- pkgs/by-name/rc/rc/package.nix | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/pkgs/by-name/rc/rc/package.nix b/pkgs/by-name/rc/rc/package.nix index 65d4a9e94dcb..1d8b372c4bc0 100644 --- a/pkgs/by-name/rc/rc/package.nix +++ b/pkgs/by-name/rc/rc/package.nix @@ -45,19 +45,11 @@ stdenv.mkDerivation (finalAttrs: { "man" ]; - # TODO: think on a less ugly fixup postPatch = '' - ed -v -s Makefile << EOS - # - remove reference to now-inexistent git index file - /version.h:/ s| .git/index|| - # - manually insert the git revision string - /v=/ c - ${"\t"}v=${builtins.substring 0 7 finalAttrs.src.rev} - . - /\.git\/index:/ d - w - q - EOS + sed -i '/main.o: version.h/ d' Makefile + cat << EOF > version.h + #define VERSION "1.7.4+${finalAttrs.src.rev}" + EOF ''; nativeBuildInputs = [