From 7d3a899c10541faeb495d201f0e25dd99c8d5fc5 Mon Sep 17 00:00:00 2001
From: seth <getchoo@tuta.io>
Date: Sat, 16 Nov 2024 20:36:59 -0500
Subject: [PATCH] containerd: use best practices

---
 pkgs/by-name/co/containerd/package.nix | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/pkgs/by-name/co/containerd/package.nix b/pkgs/by-name/co/containerd/package.nix
index 25f067e14d23..61e7ecd407e8 100644
--- a/pkgs/by-name/co/containerd/package.nix
+++ b/pkgs/by-name/co/containerd/package.nix
@@ -16,7 +16,7 @@ buildGoModule rec {
   src = fetchFromGitHub {
     owner = "containerd";
     repo = "containerd";
-    rev = "v${version}";
+    rev = "refs/tags/v${version}";
     hash = "sha256-DFAP+zjBYP2SpyD8KXGvI3i/PUZ6d4jdzGyFfr1lzj4=";
   };
 
@@ -24,6 +24,8 @@ buildGoModule rec {
 
   vendorHash = null;
 
+  strictDeps = true;
+
   nativeBuildInputs = [
     go-md2man
     util-linux
@@ -63,15 +65,15 @@ buildGoModule rec {
     inherit (nixosTests) docker;
   } // kubernetes.tests;
 
-  meta = with lib; {
-    changelog = "https://github.com/containerd/containerd/releases/tag/${src.rev}";
-    homepage = "https://containerd.io/";
+  meta = {
     description = "Daemon to control runC";
-    license = licenses.asl20;
-    maintainers = with maintainers; [
+    homepage = "https://containerd.io/";
+    changelog = "https://github.com/containerd/containerd/releases/tag/${version}";
+    license = lib.licenses.asl20;
+    maintainers = with lib.maintainers; [
       offline
       vdemeester
     ];
-    platforms = platforms.linux;
+    platforms = lib.platforms.linux;
   };
 }