From 852e541b5583bef4e24b4552bbcc9c067884fdd7 Mon Sep 17 00:00:00 2001 From: Donovan Glover Date: Fri, 8 Mar 2024 00:51:52 -0500 Subject: [PATCH 1/3] pqiv: migrate to by-name --- .../graphics/pqiv/default.nix => by-name/pq/pqiv/package.nix} | 0 pkgs/top-level/all-packages.nix | 2 -- 2 files changed, 2 deletions(-) rename pkgs/{applications/graphics/pqiv/default.nix => by-name/pq/pqiv/package.nix} (100%) diff --git a/pkgs/applications/graphics/pqiv/default.nix b/pkgs/by-name/pq/pqiv/package.nix similarity index 100% rename from pkgs/applications/graphics/pqiv/default.nix rename to pkgs/by-name/pq/pqiv/package.nix diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 97a4da725518..c2348eb873b6 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -34386,8 +34386,6 @@ with pkgs; potrace = callPackage ../applications/graphics/potrace { }; - pqiv = callPackage ../applications/graphics/pqiv { }; - qiv = callPackage ../applications/graphics/qiv { imlib2 = imlib2Full; }; From 0203229effccd31d02843c1e1a0c37b4205fa55d Mon Sep 17 00:00:00 2001 From: Donovan Glover Date: Fri, 8 Mar 2024 00:52:30 -0500 Subject: [PATCH 2/3] pqiv: add myself as maintainer --- pkgs/by-name/pq/pqiv/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/pq/pqiv/package.nix b/pkgs/by-name/pq/pqiv/package.nix index 0cc568c7e092..26794ad9fd5d 100644 --- a/pkgs/by-name/pq/pqiv/package.nix +++ b/pkgs/by-name/pq/pqiv/package.nix @@ -22,7 +22,7 @@ stdenv.mkDerivation (rec { description = "Powerful image viewer with minimal UI"; homepage = "https://www.pberndt.com/Programme/Linux/pqiv"; license = licenses.gpl3Plus; - maintainers = []; + maintainers = with maintainers; [ donovanglover ]; platforms = platforms.linux; mainProgram = "pqiv"; }; From e1090261361412c94c5e44723d1343d4c93476b3 Mon Sep 17 00:00:00 2001 From: Donovan Glover Date: Fri, 8 Mar 2024 00:59:46 -0500 Subject: [PATCH 3/3] pqiv: cleanup --- pkgs/by-name/pq/pqiv/package.nix | 31 +++++++++++++++++++++++++------ 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/pkgs/by-name/pq/pqiv/package.nix b/pkgs/by-name/pq/pqiv/package.nix index 26794ad9fd5d..d3bb3efcf606 100644 --- a/pkgs/by-name/pq/pqiv/package.nix +++ b/pkgs/by-name/pq/pqiv/package.nix @@ -1,20 +1,39 @@ -{ lib, stdenv, fetchFromGitHub, pkg-config -, ffmpeg, gtk3, imagemagick, libarchive, libspectre, libwebp, poppler +{ + lib, + stdenv, + fetchFromGitHub, + pkg-config, + ffmpeg, + gtk3, + imagemagick, + libarchive, + libspectre, + libwebp, + poppler, }: -stdenv.mkDerivation (rec { +stdenv.mkDerivation (finalAttrs: { pname = "pqiv"; version = "2.13"; src = fetchFromGitHub { owner = "phillipberndt"; repo = "pqiv"; - rev = version; - sha256 = "sha256-Jlc6sd9lRWUC1/2GZnJ0EmVRHxCXP8dTZNZEhJBS7oQ="; + rev = finalAttrs.version; + hash = "sha256-Jlc6sd9lRWUC1/2GZnJ0EmVRHxCXP8dTZNZEhJBS7oQ="; }; nativeBuildInputs = [ pkg-config ]; - buildInputs = [ ffmpeg gtk3 imagemagick libarchive libspectre libwebp poppler ]; + + buildInputs = [ + ffmpeg + gtk3 + imagemagick + libarchive + libspectre + libwebp + poppler + ]; prePatch = "patchShebangs .";