From 8dac8f7bb297c4c0cd37e9837a37dbf3445a31a2 Mon Sep 17 00:00:00 2001 From: Atemu Date: Fri, 18 Oct 2024 07:20:27 +0200 Subject: [PATCH] CONTRIBUTING: add practical advice section heading It was under the "Conventions" heading before which didn't make sense --- CONTRIBUTING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bc9927fe10d2..70e45094f269 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -615,6 +615,11 @@ Names of files and directories should be in lowercase, with dashes between words As an exception, an explicit conditional expression with null can be used when fixing a important bug without triggering a mass rebuild. If this is done a follow up pull request _should_ be created to change the code to `lib.optional(s)`. +# Practical contributing advice + +To contribute effectively and efficiently, you need to be aware of how the contributing process generally works. +This section aims to document the process as we live it in Nixpkgs to set expectations right and give practical tips on how to work with it. + ## I opened a PR, how do I get it merged? [i-opened-a-pr-how-do-i-get-it-merged]:#i-opened-a-pr-how-do-i-get-it-merged