From 9951cb98f49c96d71cb2e1f8b38f332c87f4cfce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Forsman?= Date: Sat, 23 Sep 2023 18:20:10 +0200 Subject: [PATCH] quartus-prime-lite: lower case local shell variables Upper case shell variables are generally for internal variables (SHELL, BASH_VERSION) or environment variables (PAGER, EDITOR). Other variables should be lower case. --- pkgs/applications/editors/quartus-prime/default.nix | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkgs/applications/editors/quartus-prime/default.nix b/pkgs/applications/editors/quartus-prime/default.nix index 1465f8fc7f72..ca8658395210 100644 --- a/pkgs/applications/editors/quartus-prime/default.nix +++ b/pkgs/applications/editors/quartus-prime/default.nix @@ -67,18 +67,18 @@ in buildFHSEnvChroot rec { ln -s ${desktopItem}/share/applications/* $out/share/applications ln -s ${unwrapped}/licenses/images/dc_quartus_panel_logo.png $out/share/icons/128x128/quartus.png - WRAPPER=$out/bin/${name} - EXECUTABLES="${lib.concatStringsSep " " (quartusExecutables ++ qsysExecutables ++ modelsimExecutables)}" - for executable in $EXECUTABLES; do + wrapper=$out/bin/${name} + executables="${lib.concatStringsSep " " (quartusExecutables ++ qsysExecutables ++ modelsimExecutables)}" + for executable in $executables; do mkdir -p "$(dirname "$out/$executable")" echo "#!${stdenv.shell}" >> $out/$executable - echo "$WRAPPER ${unwrapped}/$executable \"\$@\"" >> $out/$executable + echo "$wrapper ${unwrapped}/$executable \"\$@\"" >> $out/$executable done cd $out - chmod +x $EXECUTABLES + chmod +x $executables # link into $out/bin so executables become available on $PATH - ln --symbolic --relative --target-directory ./bin $EXECUTABLES + ln --symbolic --relative --target-directory ./bin $executables ''; # LD_PRELOAD fixes issues in the licensing system that cause memory corruption and crashes when