From 9bb5ec2a32e46077051c341f0b1d6a1b8a90fe3d Mon Sep 17 00:00:00 2001 From: Yiyu Zhou Date: Tue, 24 Mar 2026 15:51:28 -0700 Subject: [PATCH] gnutar: enable strictDeps --- pkgs/tools/archivers/gnutar/default.nix | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/pkgs/tools/archivers/gnutar/default.nix b/pkgs/tools/archivers/gnutar/default.nix index c7e65d9ce7f9..50742065796a 100644 --- a/pkgs/tools/archivers/gnutar/default.nix +++ b/pkgs/tools/archivers/gnutar/default.nix @@ -40,20 +40,16 @@ stdenv.mkDerivation rec { "info" ]; - nativeBuildInputs = [ autoreconfHook ]; + strictDeps = true; + + nativeBuildInputs = [ autoreconfHook ] ++ lib.optional stdenv.hostPlatform.isCygwin gettext; # Add libintl on Darwin specifically as it fails to link (or skip) # NLS on it's own: # "_libintl_textdomain", referenced from: # _main in tar.o # ld: symbol(s) not found for architecture x86_64 - buildInputs = - lib.optional aclSupport acl - ++ lib.optional stdenv.hostPlatform.isDarwin libintl - # gettext gets pulled in via autoreconfHook because strictDeps is not set, - # and is linked against. Without this, it doesn't end up in HOST_PATH. - # TODO: enable strictDeps, and either make this dependency explicit, or remove it - ++ lib.optional stdenv.hostPlatform.isCygwin gettext; + buildInputs = lib.optional aclSupport acl ++ lib.optional stdenv.hostPlatform.isDarwin libintl; # May have some issues with root compilation because the bootstrap tool # cannot be used as a login shell for now.