From bbd64b4b69c028a44bd23203c98392daad76ff95 Mon Sep 17 00:00:00 2001 From: Silvan Mosberger Date: Wed, 9 Oct 2024 18:34:34 +0200 Subject: [PATCH] workflows/codeowners: Dry mode for now Apparently it started requesting reviews from code owners already because the DRY_MODE from the global env was overridden in the local job declaration: https://github.com/NixOS/nixpkgs/pull/347354#event-14570645380 (cherry picked from commit c1710f234caaf10207e71baa6a9c7cd733c9e7d6) --- .github/workflows/codeowners.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/codeowners.yml b/.github/workflows/codeowners.yml index f4c6f23a0aef..01409dd57a66 100644 --- a/.github/workflows/codeowners.yml +++ b/.github/workflows/codeowners.yml @@ -15,11 +15,12 @@ on: env: # TODO: Once confirmed that this works by seeing that the action would request # reviews from the same people (or refuse for wrong base branches), - # move all entries from CODEOWNERS to OWNERS and change this value here - # OWNERS_FILE: .github/OWNERS + # move all entries from CODEOWNERS to OWNERS, remove these two lines and uncomment the ones below OWNERS_FILE: .github/CODEOWNERS - # Also remove this DRY_MODE: 1 + # OWNERS_FILE: .github/OWNERS + # # Don't do anything on draft PRs + # DRY_MODE: ${{ github.event.pull_request.draft && '1' || '' }} jobs: # Check that code owners is valid @@ -84,5 +85,3 @@ jobs: run: result/bin/request-reviews.sh ${{ github.repository }} ${{ github.event.number }} "$OWNERS_FILE" env: GH_TOKEN: ${{ steps.app-token.outputs.token }} - # Don't do anything on draft PRs - DRY_MODE: ${{ github.event.pull_request.draft && '1' || '' }}