From fbfa6ac0778f90029c30b21d3cff7f793c8f20ae Mon Sep 17 00:00:00 2001 From: worldofpeace Date: Sun, 9 Feb 2020 16:21:52 -0500 Subject: [PATCH 1/3] testing-python: fix runInMachine The test script's were unported. It's unclear whether the preBuild or postBuild will work as expect, due to the linting of the test scripts. (cherry picked from commit fa9af83e960aa982302bd367d8159f365eaa7471) --- nixos/lib/testing-python.nix | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/nixos/lib/testing-python.nix b/nixos/lib/testing-python.nix index a7f6d7926514..36394c594b2b 100644 --- a/nixos/lib/testing-python.nix +++ b/nixos/lib/testing-python.nix @@ -218,12 +218,12 @@ in rec { ''; testScript = '' - startAll; - $client->waitForUnit("multi-user.target"); + start_all() + client.wait_for_unit("multi-user.target") ${preBuild} - $client->succeed("env -i ${bash}/bin/bash ${buildrunner} /tmp/xchg/saved-env >&2"); + client.succeed("env -i ${bash}/bin/bash ${buildrunner} /tmp/xchg/saved-env >&2") ${postBuild} - $client->succeed("sync"); # flush all data before pulling the plug + client.succeed("sync") # flush all data before pulling the plug ''; vmRunCommand = writeText "vm-run" '' @@ -274,7 +274,7 @@ in rec { machine = client; preBuild = '' - $client->waitForX; + client.wait_for_x() ''; } // args); From aea80290efa5a59829d23dc5c4535a7bc2951fd0 Mon Sep 17 00:00:00 2001 From: worldofpeace Date: Sun, 9 Feb 2020 16:23:35 -0500 Subject: [PATCH 2/3] testing-python: readd auto displayManager we import it for the runInMachineWithX (cherry picked from commit 88f76812f23a15546ec4455a0ecb9ca735150b18) --- nixos/lib/testing-python.nix | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/nixos/lib/testing-python.nix b/nixos/lib/testing-python.nix index 36394c594b2b..6663864f1e56 100644 --- a/nixos/lib/testing-python.nix +++ b/nixos/lib/testing-python.nix @@ -263,9 +263,12 @@ in rec { { ... }: { inherit require; + imports = [ + ../tests/common/auto.nix + ]; virtualisation.memorySize = 1024; services.xserver.enable = true; - services.xserver.displayManager.auto.enable = true; + test-support.displayManager.auto.enable = true; services.xserver.displayManager.defaultSession = "none+icewm"; services.xserver.windowManager.icewm.enable = true; }; From d074d34343faf3a33dfb81e13ea1e97363da933a Mon Sep 17 00:00:00 2001 From: worldofpeace Date: Sun, 9 Feb 2020 16:27:01 -0500 Subject: [PATCH 3/3] testing: fix runInMachineWithX (cherry picked from commit 5507e09618c2e2d4a51377d73eb77b3cb9eef01c) --- nixos/lib/testing.nix | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/nixos/lib/testing.nix b/nixos/lib/testing.nix index c82abd1f9900..7d6a5c0a2900 100644 --- a/nixos/lib/testing.nix +++ b/nixos/lib/testing.nix @@ -250,9 +250,12 @@ in rec { { ... }: { inherit require; + imports = [ + ../tests/common/auto.nix + ]; virtualisation.memorySize = 1024; services.xserver.enable = true; - services.xserver.displayManager.auto.enable = true; + test-support.displayManager.auto.enable = true; services.xserver.displayManager.defaultSession = "none+icewm"; services.xserver.windowManager.icewm.enable = true; };