From c642405dbe929fd27d7dcf38515c13c15973cbda Mon Sep 17 00:00:00 2001 From: Michael Daniels Date: Thu, 14 May 2026 22:00:55 -0400 Subject: [PATCH] ci/github-script/prepare: fix review dismissals I broke this in https://github.com/NixOS/nixpkgs/commit/1c3e1495465d571229801c334e4d6b25a1d1998e#diff-9baa1b84a40210e20622eeb04bea6db28ef3ff90dea79aa54ba9d1e27c150b21. See #520239 for an example of this not working. --- ci/github-script/prepare.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/github-script/prepare.js b/ci/github-script/prepare.js index d4d69eb71692..7543374dfaa6 100644 --- a/ci/github-script/prepare.js +++ b/ci/github-script/prepare.js @@ -181,9 +181,9 @@ module.exports = async ({ github, context, core, dry }) => { event: 'REQUEST_CHANGES', reviewKey, }) + } else { + await dismissReviews({ github, context, core, dry, reviewKey }) } - } else { - await dismissReviews({ github, context, core, dry, reviewKey }) } let mergedSha, targetSha