From d4369fbe36c7804bd4d6eaa75ffbd97ccf940a1c Mon Sep 17 00:00:00 2001 From: Michael Weiss Date: Fri, 22 Jan 2021 12:19:27 +0100 Subject: [PATCH] chromium: Don't set "channel" in the environment The "channel" variable shouldn't be part of the final derivation. This also makes it possible to avoid unnecessary rebuilds for identical channels (e.g. major updates are tested via the "beta" channel first and usually neither the source-code archive nor the dependencies change when the update makes it into the "stable" channel - this means we could better use chromiumBeta to test major updates in advance). (cherry picked from commit fac05ac69522b1ae2fed1933c4dc0154734de927) --- pkgs/applications/networking/browsers/chromium/common.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/networking/browsers/chromium/common.nix b/pkgs/applications/networking/browsers/chromium/common.nix index 3cd469694e44..3f3cc2ba921e 100644 --- a/pkgs/applications/networking/browsers/chromium/common.nix +++ b/pkgs/applications/networking/browsers/chromium/common.nix @@ -117,7 +117,7 @@ let base = rec { name = "${packageName}-unwrapped-${version}"; inherit (upstream-info) version; - inherit channel packageName buildType buildPath; + inherit packageName buildType buildPath; src = fetchurl { url = "https://commondatastorage.googleapis.com/chromium-browser-official/chromium-${version}.tar.xz";