From b3d550d392778c2eec03c4c8f574732892394ea0 Mon Sep 17 00:00:00 2001 From: Romanos Skiadas Date: Tue, 17 Aug 2021 20:47:28 +0300 Subject: [PATCH 1/2] mopidy-spotify: Fix warning about not using fetchFromGitHub --- pkgs/applications/audio/mopidy/spotify.nix | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/pkgs/applications/audio/mopidy/spotify.nix b/pkgs/applications/audio/mopidy/spotify.nix index 93f62e23f3a9..188993ed16e8 100644 --- a/pkgs/applications/audio/mopidy/spotify.nix +++ b/pkgs/applications/audio/mopidy/spotify.nix @@ -1,12 +1,14 @@ -{ lib, fetchurl, pythonPackages, mopidy }: +{ lib, fetchFromGitHub, pythonPackages, mopidy }: pythonPackages.buildPythonApplication rec { pname = "mopidy-spotify"; version = "4.1.1"; - src = fetchurl { - url = "https://github.com/mopidy/mopidy-spotify/archive/v${version}.tar.gz"; - sha256 = "0054gqvnx3brpfxr06dcby0z0dirwv9ydi6gj5iz0cxn0fbi6gv2"; + src = fetchFromGitHub { + owner = "mopidy"; + repo = "mopidy-spotify"; + rev = "v${version}"; + sha256 = "1qsac2yy26cdlsmxd523v8ayacs0s6jj9x79sngwap781i63zqrm"; }; propagatedBuildInputs = [ mopidy pythonPackages.pyspotify ]; From f33039ed8a84f529b3ef96724d3e585a58d49ef8 Mon Sep 17 00:00:00 2001 From: Romanos Skiadas Date: Tue, 17 Aug 2021 20:55:36 +0300 Subject: [PATCH 2/2] mopidy-spotify: add myself as maintainer It's a simple enough package, I do use it and it's unmaintained, I might as well volunteer for it. --- maintainers/maintainer-list.nix | 6 ++++++ pkgs/applications/audio/mopidy/spotify.nix | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/maintainers/maintainer-list.nix b/maintainers/maintainer-list.nix index 9bf862302d6b..aa26bd0dc97e 100644 --- a/maintainers/maintainer-list.nix +++ b/maintainers/maintainer-list.nix @@ -12316,4 +12316,10 @@ github = "zupo"; githubId = 311580; }; + rski = { + name = "rski"; + email = "rom.skiad+nix@gmail.com"; + github = "rski"; + githubId = 2960312; + }; } diff --git a/pkgs/applications/audio/mopidy/spotify.nix b/pkgs/applications/audio/mopidy/spotify.nix index 188993ed16e8..ed68769f6650 100644 --- a/pkgs/applications/audio/mopidy/spotify.nix +++ b/pkgs/applications/audio/mopidy/spotify.nix @@ -19,7 +19,7 @@ pythonPackages.buildPythonApplication rec { homepage = "https://www.mopidy.com/"; description = "Mopidy extension for playing music from Spotify"; license = licenses.asl20; - maintainers = []; - hydraPlatforms = []; + maintainers = with maintainers; [ rski ]; + hydraPlatforms = [ ]; }; }