From de00611d2f1a40b537f485c59f70cd655cc908c4 Mon Sep 17 00:00:00 2001
From: Florian Franzen <Florian.Franzen@gmail.com>
Date: Mon, 28 Sep 2026 15:40:28 +0200
Subject: [PATCH] jp2a: add update script and version check, modernize

---
 pkgs/by-name/jp/jp2a/package.nix | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/pkgs/by-name/jp/jp2a/package.nix b/pkgs/by-name/jp/jp2a/package.nix
index 00cf9b63f5c1..04f37b977642 100644
--- a/pkgs/by-name/jp/jp2a/package.nix
+++ b/pkgs/by-name/jp/jp2a/package.nix
@@ -11,11 +11,13 @@
   bash-completion,
   libwebp,
   libexif,
+  nix-update-script,
+  versionCheckHook,
 }:
 
 stdenv.mkDerivation (finalAttrs: {
-  version = "1.3.3";
   pname = "jp2a";
+  version = "1.3.3";
 
   src = fetchFromGitHub {
     owner = "Talinx";
@@ -24,16 +26,16 @@ stdenv.mkDerivation (finalAttrs: {
     hash = "sha256-GvPRLYrqZyzk24RmJJ1VcnXo6uda50qqqRA/pioPm5Q=";
   };
 
-  makeFlags = [ "PREFIX=$(out)" ];
+  makeFlags = [ "PREFIX=${placeholder "out"}" ];
 
   nativeBuildInputs = [
     autoreconfHook
     autoconf-archive
     pkg-config
-    bash-completion
   ];
 
   buildInputs = [
+    bash-completion
     libjpeg
     libpng
     ncurses
@@ -41,12 +43,23 @@ stdenv.mkDerivation (finalAttrs: {
     libexif
   ];
 
-  installFlags = [ "bashcompdir=\${out}/share/bash-completion/completions" ];
+  installFlags = [ "bashcompdir=${placeholder "out"}/share/bash-completion/completions" ];
+
+  __structuredAttrs = true;
+
+  strictDeps = true;
+
+  nativeInstallCheckInputs = [ versionCheckHook ];
+
+  doInstallCheck = true;
+
+  passthru.updateScript = nix-update-script { };
 
   meta = {
     broken = stdenv.hostPlatform.isDarwin;
     homepage = "https://github.com/Talinx/jp2a";
     description = "Small utility that converts JPG images to ASCII";
+    changelog = "https://github.com/Talinx/jp2a/releases/tag/${finalAttrs.src.tag}";
     license = lib.licenses.gpl2Only;
     maintainers = [ lib.maintainers.FlorianFranzen ];
     platforms = lib.platforms.unix;