From 194e35dd632a7c1a86b7d2c70c45c7ccb8321949 Mon Sep 17 00:00:00 2001 From: Theodore Ni <3806110+tjni@users.noreply.github.com> Date: Sat, 9 Nov 2024 01:49:24 -0800 Subject: [PATCH 1/2] mysql-shell: add libutil on darwin; refactor to new SDK pattern --- pkgs/development/tools/mysql-shell/8.nix | 7 +++---- pkgs/top-level/all-packages.nix | 2 -- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/pkgs/development/tools/mysql-shell/8.nix b/pkgs/development/tools/mysql-shell/8.nix index dde88159f08b..79f8f638c08c 100644 --- a/pkgs/development/tools/mysql-shell/8.nix +++ b/pkgs/development/tools/mysql-shell/8.nix @@ -5,9 +5,8 @@ , fetchurl , git , cctools -, DarwinTools +, darwin , makeWrapper -, CoreServices , bison , openssl , protobuf @@ -73,7 +72,7 @@ stdenv.mkDerivation (finalAttrs: { nativeBuildInputs = [ pkg-config cmake git bison makeWrapper ] ++ lib.optionals (!stdenv.hostPlatform.isDarwin) [ rpcsvc-proto ] - ++ lib.optionals stdenv.hostPlatform.isDarwin [ cctools DarwinTools ]; + ++ lib.optionals stdenv.hostPlatform.isDarwin [ cctools darwin.DarwinTools ]; buildInputs = [ curl @@ -96,7 +95,7 @@ stdenv.mkDerivation (finalAttrs: { antlr.runtime.cpp ] ++ pythonDeps ++ lib.optionals stdenv.hostPlatform.isLinux [ libtirpc ] - ++ lib.optionals stdenv.hostPlatform.isDarwin [ CoreServices ]; + ++ lib.optionals stdenv.hostPlatform.isDarwin [ darwin.libutil ]; preConfigure = '' # Build MySQL diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 2f5f592e8399..6b439f67fd66 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -540,8 +540,6 @@ with pkgs; inherit ({ mysql-shell_8 = callPackage ../development/tools/mysql-shell/8.nix { - inherit (darwin) DarwinTools; - inherit (darwin.apple_sdk.frameworks) CoreServices; antlr = antlr4_10; icu = icu73; protobuf = protobuf_24; From 9ba75eb753b55910ccd974bd3e7e61f00eda493f Mon Sep 17 00:00:00 2001 From: Theodore Ni <3806110+tjni@users.noreply.github.com> Date: Sat, 9 Nov 2024 01:50:56 -0800 Subject: [PATCH 2/2] mysql-shell-innovation: add libutil on darwin; refactor to new SDK pattern --- pkgs/development/tools/mysql-shell/innovation.nix | 7 +++---- pkgs/top-level/all-packages.nix | 2 -- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/pkgs/development/tools/mysql-shell/innovation.nix b/pkgs/development/tools/mysql-shell/innovation.nix index 411c867334d0..573245955006 100644 --- a/pkgs/development/tools/mysql-shell/innovation.nix +++ b/pkgs/development/tools/mysql-shell/innovation.nix @@ -5,9 +5,8 @@ , fetchurl , git , cctools -, DarwinTools +, darwin , makeWrapper -, CoreServices , bison , openssl , protobuf @@ -73,7 +72,7 @@ stdenv.mkDerivation (finalAttrs: { nativeBuildInputs = [ pkg-config cmake git bison makeWrapper ] ++ lib.optionals (!stdenv.hostPlatform.isDarwin) [ rpcsvc-proto ] - ++ lib.optionals stdenv.hostPlatform.isDarwin [ cctools DarwinTools ]; + ++ lib.optionals stdenv.hostPlatform.isDarwin [ cctools darwin.DarwinTools ]; buildInputs = [ curl @@ -96,7 +95,7 @@ stdenv.mkDerivation (finalAttrs: { antlr.runtime.cpp ] ++ pythonDeps ++ lib.optionals stdenv.hostPlatform.isLinux [ libtirpc ] - ++ lib.optionals stdenv.hostPlatform.isDarwin [ CoreServices ]; + ++ lib.optionals stdenv.hostPlatform.isDarwin [ darwin.libutil ]; preConfigure = '' # Build MySQL diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 6b439f67fd66..b6c4bf2e8d35 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -549,8 +549,6 @@ with pkgs; ; mysql-shell-innovation = callPackage ../development/tools/mysql-shell/innovation.nix { - inherit (darwin) DarwinTools; - inherit (darwin.apple_sdk.frameworks) CoreServices; antlr = antlr4_10; icu = icu73; protobuf = protobuf_24;