From dfab5140e248ad465d107f3112f4e5d0c64942ef Mon Sep 17 00:00:00 2001 From: Ihar Hrachyshka Date: Sat, 19 Sep 2026 00:20:48 -0400 Subject: [PATCH] pdfium: skip macOS 27 image failures on Darwin Assisted-by: Codex, gpt-5.6-sol high --- .../darwin-27-failing-embedder-tests.txt | 77 +++++++++++++++++++ pkgs/by-name/pd/pdfium/package.nix | 8 +- 2 files changed, 84 insertions(+), 1 deletion(-) create mode 100644 pkgs/by-name/pd/pdfium/darwin-27-failing-embedder-tests.txt diff --git a/pkgs/by-name/pd/pdfium/darwin-27-failing-embedder-tests.txt b/pkgs/by-name/pd/pdfium/darwin-27-failing-embedder-tests.txt new file mode 100644 index 000000000000..a47b7d21d8f5 --- /dev/null +++ b/pkgs/by-name/pd/pdfium/darwin-27-failing-embedder-tests.txt @@ -0,0 +1,77 @@ +CPDFSecurityHandlerEmbedderTest.Bug1124998 +CPDFSecurityHandlerEmbedderTest.OwnerPasswordVersion2Latin1 +CPDFSecurityHandlerEmbedderTest.OwnerPasswordVersion2UTF8 +CPDFSecurityHandlerEmbedderTest.OwnerPasswordVersion3Latin1 +CPDFSecurityHandlerEmbedderTest.OwnerPasswordVersion3UTF8 +CPDFSecurityHandlerEmbedderTest.OwnerPasswordVersion5Latin1 +CPDFSecurityHandlerEmbedderTest.OwnerPasswordVersion5UTF8 +CPDFSecurityHandlerEmbedderTest.OwnerPasswordVersion6Latin1 +CPDFSecurityHandlerEmbedderTest.OwnerPasswordVersion6UTF8 +CPDFSecurityHandlerEmbedderTest.PasswordAfterGenerateSave +CPDFSecurityHandlerEmbedderTest.UserPasswordVersion2Latin1 +CPDFSecurityHandlerEmbedderTest.UserPasswordVersion2UTF8 +CPDFSecurityHandlerEmbedderTest.UserPasswordVersion3Latin1 +CPDFSecurityHandlerEmbedderTest.UserPasswordVersion3UTF8 +CPDFSecurityHandlerEmbedderTest.UserPasswordVersion5Latin1 +CPDFSecurityHandlerEmbedderTest.UserPasswordVersion5UTF8 +CPDFSecurityHandlerEmbedderTest.UserPasswordVersion6Latin1 +CPDFSecurityHandlerEmbedderTest.UserPasswordVersion6UTF8 +FPDFAnnotEmbedderTest.AddAndModifyImage +FPDFAnnotEmbedderTest.AddAndModifyPath +FPDFAnnotEmbedderTest.AddAndModifyText +FPDFAnnotEmbedderTest.AddAndSaveLinkAnnotation +FPDFAnnotEmbedderTest.AnnotationBorderRendering +FPDFAnnotEmbedderTest.FocusableAnnotRendering +FPDFAnnotEmbedderTest.GetSetStringValue +FPDFAnnotEmbedderTest.ModifyRectQuadpointsWithAP +FPDFAnnotEmbedderTest.SetFontColor +FPDFEditEmbedderTest.AddExistingMarkCompressedStream +FPDFEditEmbedderTest.AddMarkCompressedStream +FPDFEditEmbedderTest.AddMarkedText +FPDFEditEmbedderTest.AddMarkedTextWithFloat +FPDFEditEmbedderTest.AddStandardFontText +FPDFEditEmbedderTest.AddStandardFontText2 +FPDFEditEmbedderTest.AddTrueTypeFontText +FPDFEditEmbedderTest.Bug1574 +FPDFEditEmbedderTest.Bug1893 +FPDFEditEmbedderTest.Bug410996566 +FPDFEditEmbedderTest.Bug461845674 +FPDFEditEmbedderTest.GetAndSetMatrixForFormWithText +FPDFEditEmbedderTest.ModifyFormObject +FPDFEditEmbedderTest.PathOnTopOfText +FPDFEditEmbedderTest.RemoveAllFromStream +FPDFEditEmbedderTest.RemoveExistingPageObjectSplitStreamsLonely +FPDFEditEmbedderTest.RemoveExistingPageObjectSplitStreamsNotLonely +FPDFEditEmbedderTest.RemoveFirstFromSingleStream +FPDFEditEmbedderTest.RemoveLastFromSingleStream +FPDFEditEmbedderTest.RemoveMarkedObjectsPrime +FPDFEditEmbedderTest.RemoveTextObject +FPDFEditEmbedderTest.RemoveTextObjectWithTwoPagesSharingContentArrayAndResources +FPDFEditEmbedderTest.RemoveTextObjectWithTwoPagesSharingContentStreamAndResources +FPDFEditEmbedderTest.RemoveTextObjectWithTwoPagesSharingResourcesDict +FPDFEditEmbedderTest.SetPositions +FPDFEditEmbedderTest.SetText +FPDFEditEmbedderTest.SetTextKeepClippingPath +FPDFEditEmbedderTest.SetTextRenderMode +FPDFFlattenEmbedderTest.Bug861842 +FPDFFlattenEmbedderTest.Bug889099 +FPDFFormFillComboBoxFormEmbedderTest.FormComboBoxBiDiLiveEdit +FPDFFormFillEmbedderTest.Bug1302455EditBothForms +FPDFFormFillEmbedderTest.Bug1302455EditFirstForm +FPDFFormFillEmbedderTest.Bug1302455EditSecondForm +FPDFFormFillEmbedderTest.FormText +FPDFFormFillEmbedderTest.RemoveFormFieldHighlight +FPDFFormFillTextFormEmbedderTest.FormTextFieldBiDiLiveEdit +FPDFPPOEmbedderTest.ImportWithZeroLengthStream +FPDFParserDecodeEmbedderTest.Bug455199 +FPDFProgressiveRenderEmbedderTest.RenderAnnotWithPause +FPDFProgressiveRenderEmbedderTest.RenderFormsWithPause +FPDFProgressiveRenderEmbedderTest.RenderHighlightWithColorScheme +FPDFProgressiveRenderEmbedderTest.RenderHighlightWithColorSchemeAndConvertFillToStroke +FPDFProgressiveRenderEmbedderTest.RenderStampWithColorScheme +FPDFProgressiveRenderEmbedderTest.RenderTextWithColorScheme +FPDFProgressiveRenderEmbedderTest.RenderWithPause +FPDFProgressiveRenderEmbedderTest.RenderWithoutPause +FPDFSaveWithFontSubsetEmbedderTest.SaveWithSubsetMultipleFontsMultipleTexts +FPDFViewEmbedderTest.RenderBug664284WithNoNativeText +FPDFViewEmbedderTest.RenderHelloWorldWithFlags diff --git a/pkgs/by-name/pd/pdfium/package.nix b/pkgs/by-name/pd/pdfium/package.nix index 66102cb7d717..9b304afdc951 100644 --- a/pkgs/by-name/pd/pdfium/package.nix +++ b/pkgs/by-name/pd/pdfium/package.nix @@ -177,6 +177,10 @@ let "RetainPtr.SetContains" ]; + darwin27FailingEmbedderTests = lib.filter (test: test != "") ( + lib.splitString "\n" (builtins.readFile ./darwin-27-failing-embedder-tests.txt) + ); + disabledEmbedderTests = [ # These assert exact serialized PDF and font-subset output. With system # libraries, output differs from upstream's in-tree stack; known @@ -195,7 +199,9 @@ let "FPDFProgressiveRenderEmbedderTest.RenderHighlightWithColorScheme" "FPDFProgressiveRenderEmbedderTest.RenderHighlightWithColorSchemeAndConvertFillToStroke" "FPDFAnnotEmbedderTest.ModifyRectQuadpointsWithAP" - ]; + ] + # Changes to CoreGraphics rendering broke these tests when run on macOS 27+. + ++ lib.optionals stdenv.hostPlatform.isDarwin darwin27FailingEmbedderTests; mkDisabledGtestFilter = disabledTests: "-${lib.concatStringsSep ":" disabledTests}"; unitTestFilter = mkDisabledGtestFilter disabledUnitTests;