From fe49b3cf3b6947c64e1c32b34b96fef7d4eaa31c Mon Sep 17 00:00:00 2001 From: Morgan Jones Date: Mon, 5 May 2025 23:32:00 -0700 Subject: [PATCH] ci/eval: use correct maintainer and team positions We need to pass through the maintainers and teams positions from the original meta so pings work correctly, since check-meta clobbers the original attribute positions in them. Tested with `maintainers/scripts/get-maintainer-pings-between.sh` on a handful of major packages maintained by both individuals and teams. (cherry picked from commit 92bd743239823dc7c80572539528398f722a9278) --- ci/eval/compare/maintainers.nix | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ci/eval/compare/maintainers.nix b/ci/eval/compare/maintainers.nix index 8fb43be4d8e7..b8a45e217155 100644 --- a/ci/eval/compare/maintainers.nix +++ b/ci/eval/compare/maintainers.nix @@ -53,9 +53,7 @@ let // { # TODO: Refactor this so we can ping entire teams instead of the individual members. # Note that this will require keeping track of GH team IDs in "maintainers/teams.nix". - maintainers = - meta.maintainers or [ ] - ++ lib.flatten (map (team: team.members or [ ]) (meta.teams or [ ])); + maintainers = meta.maintainers or [ ]; } ) attrsWithPackages;