From ff94a4d433181e52a97cb4eaa2af112ff5844ade Mon Sep 17 00:00:00 2001 From: Marie Ramlow Date: Fri, 22 Aug 2025 17:00:25 +0200 Subject: [PATCH] {ngtcp2, curl, nghttp2}: use openssl instead of quictls --- pkgs/by-name/cu/curlMinimal/package.nix | 14 ++++---------- pkgs/by-name/ng/nghttp2/package.nix | 4 +--- pkgs/development/libraries/ngtcp2/default.nix | 4 ++-- 3 files changed, 7 insertions(+), 15 deletions(-) diff --git a/pkgs/by-name/cu/curlMinimal/package.nix b/pkgs/by-name/cu/curlMinimal/package.nix index a2d1835da18e..907c81063233 100644 --- a/pkgs/by-name/cu/curlMinimal/package.nix +++ b/pkgs/by-name/cu/curlMinimal/package.nix @@ -34,7 +34,6 @@ http3Support ? false, nghttp3, ngtcp2, - quictls, websocketSupport ? false, idnSupport ? false, libidn2, @@ -85,10 +84,6 @@ assert ]) > 1 ); -let - openssl' = if http3Support then quictls else openssl; -in - stdenv.mkDerivation (finalAttrs: { pname = "curl"; version = "8.14.1"; @@ -137,7 +132,7 @@ stdenv.mkDerivation (finalAttrs: { nativeCheckInputs = [ # See https://github.com/curl/curl/pull/16928 - openssl' + openssl ]; # Zlib and OpenSSL must be propagated because `libcurl.la' contains @@ -156,7 +151,7 @@ stdenv.mkDerivation (finalAttrs: { ] ++ lib.optional idnSupport libidn2 ++ lib.optional ldapSupport openldap - ++ lib.optional opensslSupport openssl' + ++ lib.optional opensslSupport openssl ++ lib.optional pslSupport libpsl ++ lib.optional rtmpSupport rtmpdump ++ lib.optional scpSupport libssh2 @@ -190,7 +185,7 @@ stdenv.mkDerivation (finalAttrs: { (lib.withFeatureAs brotliSupport "brotli" (lib.getDev brotli)) (lib.withFeatureAs gnutlsSupport "gnutls" (lib.getDev gnutls)) (lib.withFeatureAs idnSupport "libidn2" (lib.getDev libidn2)) - (lib.withFeatureAs opensslSupport "openssl" (lib.getDev openssl')) + (lib.withFeatureAs opensslSupport "openssl" (lib.getDev openssl)) (lib.withFeatureAs scpSupport "libssh2" (lib.getDev libssh2)) (lib.withFeatureAs wolfsslSupport "wolfssl" (lib.getDev wolfssl)) ] @@ -255,8 +250,7 @@ stdenv.mkDerivation (finalAttrs: { useThisCurl = attr: attr.override { curl = finalAttrs.finalPackage; }; in { - inherit opensslSupport; - openssl = openssl'; + inherit opensslSupport openssl; tests = { withCheck = finalAttrs.finalPackage.overrideAttrs (_: { doCheck = true; diff --git a/pkgs/by-name/ng/nghttp2/package.nix b/pkgs/by-name/ng/nghttp2/package.nix index 39b3c9fbc2c9..b6dd6be98757 100644 --- a/pkgs/by-name/ng/nghttp2/package.nix +++ b/pkgs/by-name/ng/nghttp2/package.nix @@ -18,7 +18,6 @@ enableHttp3 ? false, ngtcp2, nghttp3, - quictls, enableJemalloc ? false, jemalloc, enablePython ? false, @@ -68,15 +67,14 @@ stdenv.mkDerivation rec { c-aresMinimal libev zlib + openssl ] - ++ lib.optionals (enableApp && !enableHttp3) [ openssl ] ++ lib.optionals (enableGetAssets) [ libxml2 ] ++ lib.optionals (enableHpack) [ jansson ] ++ lib.optionals (enableJemalloc) [ jemalloc ] ++ lib.optionals (enableHttp3) [ ngtcp2 nghttp3 - quictls ] ++ lib.optionals (enablePython) [ python3 ]; diff --git a/pkgs/development/libraries/ngtcp2/default.nix b/pkgs/development/libraries/ngtcp2/default.nix index 533bb9f2c0e6..916d9d5d770c 100644 --- a/pkgs/development/libraries/ngtcp2/default.nix +++ b/pkgs/development/libraries/ngtcp2/default.nix @@ -6,7 +6,7 @@ brotli, libev, nghttp3, - quictls, + openssl, withJemalloc ? false, jemalloc, curlHTTP3, @@ -32,7 +32,7 @@ stdenv.mkDerivation (finalAttrs: { brotli libev nghttp3 - quictls + openssl ] ++ lib.optional withJemalloc jemalloc;