From 91599af99b07ed81704daa3a531ca910b2aab7cc Mon Sep 17 00:00:00 2001 From: Tyce Herrman Date: Wed, 5 Aug 2026 18:15:45 -0400 Subject: [PATCH] freetube: fix Darwin code signing FreeTube 0.25.1 enables Electron-builder's ad-hoc signing by setting mac.identity to "-". Electron-builder passes Apple codesign flags that nixpkgs' sigtool does not support, causing the Darwin build to fail. Disable Electron-builder signing and let autoSignDarwinBinariesHook add the required ad-hoc signatures after installation. Assisted-by: Codex (GPT-5) (cherry picked from commit fbfce5921bf96abd672e3e3aa391c7b60bdee121) --- pkgs/by-name/fr/freetube/package.nix | 4 ++++ pkgs/by-name/fr/freetube/patch-build-script.patch | 9 +++++++++ 2 files changed, 13 insertions(+) diff --git a/pkgs/by-name/fr/freetube/package.nix b/pkgs/by-name/fr/freetube/package.nix index ed4e7f35e84e..10f8c8f1e7ea 100644 --- a/pkgs/by-name/fr/freetube/package.nix +++ b/pkgs/by-name/fr/freetube/package.nix @@ -13,6 +13,7 @@ makeShellWrapper, copyDesktopItems, electron, + darwin, nixosTests, }: @@ -67,6 +68,9 @@ stdenvNoCC.mkDerivation (finalAttrs: { pnpm makeShellWrapper copyDesktopItems + ] + ++ lib.optionals stdenvNoCC.hostPlatform.isDarwin [ + darwin.autoSignDarwinBinariesHook ]; installPhase = '' diff --git a/pkgs/by-name/fr/freetube/patch-build-script.patch b/pkgs/by-name/fr/freetube/patch-build-script.patch index f925f420212a..a4a386c9d6d5 100644 --- a/pkgs/by-name/fr/freetube/patch-build-script.patch +++ b/pkgs/by-name/fr/freetube/patch-build-script.patch @@ -11,3 +11,12 @@ index bef1f6f1d..d2ee86611 100644 appId: `io.freetubeapp.${packageDetails.name}`, copyright: 'Copyleft © 2020-2026 freetubeapp@protonmail.com', // asar: false, +@@ -99,7 +101,7 @@ export default { + // Enable ad-hoc signing + // If we skip signing entirely, macOS says that the application is damaged, which makes users open bug reports. + // With an ad-hoc signature it still refuses to launch by default but with the reason that it cannot verify the signature +- identity: '-' ++ identity: null + }, + win: { + icon: '_icons/icon.ico',