10 Commits

Author SHA1 Message Date
Michael Daniels
1c3e149546 Reapply {ci,workflows}: allow multiple blocking reviews"
A couple of bugfixes, but the problem was that the apps weren't installed.
2026-05-03 18:17:03 -04:00
Michael Daniels
cd2e5a371b Revert "{ci,workflows}: allow multiple blocking reviews" 2026-05-03 13:21:39 -04:00
Michael Daniels
636fc13366 {ci,workflows}: allow multiple blocking reviews 2026-05-02 18:09:26 -04:00
Michael Daniels
7a74549a85 ci/github-script/reviews: detect reviews belonging to commits.js
See comment, but TLDR this is for backwards-compatibility.

(See 479628, where it failed to dismiss after fixing.)

We don't bother with `prepare.js` because it always errors
(and so should never be dismissed).

I have simply added the needed comments to each of `check-target-branch.js`'s
pre-existing reviews, because there are so few.
2026-01-26 19:37:56 -05:00
Michael Daniels
4447561c05 ci/github-script/{reviews,check-target-branch,commits,prepare}: add sticky review support 2026-01-25 19:10:50 -05:00
Michael Daniels
3fb23e6837 ci/github-script/reviews: enable typescript 2026-01-25 16:53:07 -05:00
Michael Daniels
0ba1ea61e3 ci/github-script/reviews: allow leaving review comments 2026-01-19 11:29:53 -05:00
Michael Daniels
e05e984689 ci/github-script/reviews: rework dismissal/non-posting logic
Dismissals are done automatically by commits.js, even for reviews from
check-target-branches.js. This is not desirable.

The solution is
(1) do not decline to post a review because it was already dismissed
    (because it may have not been dismissed by a human, and circumstances may
    have changed), and
(2) reword the auto-dismissal message to not imply that whatever
    problems were present are fixed.
2026-01-19 11:29:47 -05:00
Wolfgang Walther
41ae23c0e7 ci,workflows: deal with ghost reviews
When a user deletes their account, they appear as a "ghost user". This
user is represented as `null` on API requests. If such a user had posted
a review before, this breaks a few places, which assume to be able to
access `user.login`.
2025-08-25 15:17:01 +02:00
Wolfgang Walther
c96b0e6d3d ci/github-script/commits: split review function into separate file
This allows re-using postReview in the next commit.
2025-08-24 12:14:54 +02:00