Apparently any effects from this change haven’t shown up noticeably
in GitHub’s metrics, to the point where they’re not sure if it
was taking effect on the backend. Our contact is going to look at
getting something into the API response to help debug whether it’s
actually working or not, but agreed that we should just revert for
now. Since they have apparently reduced replica sync issues further
through other changes on their end, there shouldn’t be any urgent
need to make any changes here anyway.
This reverts commit 18b30c8ce1.
When a maintainer deletes their GitHub account, the bot would crash with a 404 error when trying to fetch their user info via `/user/{id}`.
This caused the scheduled bot workflow to fail repeatedly until manual intervention (e.g., closing/reopening the affected PR to clear the requested reviewer).
Fix by returning null from getUser() for 404 responses and filtering out null users when building the reviewers list.
Dismissals are done automatically by commits.js, even for reviews from
check-target-branches.js. This is not desirable.
The solution is
(1) do not decline to post a review because it was already dismissed
(because it may have not been dismissed by a human, and circumstances may
have changed), and
(2) reword the auto-dismissal message to not imply that whatever
problems were present are fixed.
This restricts github automatically merging master with commit message
"Merge branch 'NixOS:master' into ...". Although we don't explicitly
prohibit not space after colons, we don't use it in any of the examples.
It's also enforced in https://www.conventionalcommits.org/en/v1.0.0/
Librewolf is in a bad shape. Not just in nixpkgs, but upstream as well.
In nixpkgs, browsers have been a constant painful argument.
I have written up #405187 to clarify some security requirements for packages.
While Librewolf doesn't immediately violate the requirements outlined there,
we should strive for better than just the absolute minimum.
Personally, I no longer feel confident in my ability to adequately contribute,
test, and backport Librewolf updates. The past few months have been stressful IRL,
and maintaining a browser in nixpkgs is no longer sustainable for me.
In the time I intended to take a break, #471511 was opened to update to 146.0.1.
This was not merged in a timely manner, despite me not being the only committer among LW maintainers.
librewolf-bin isn't looking much better. #464467 is open since Nov 24th,
entirely unacceptable for a browser. The single remaining maintainer, @DominicWrege,
already proposed dropping the package entirely, LeSuisse marked it vulnerable in the meantime.
The situation upstream does not look much better. Checking the [commit history](https://codeberg.org/librewolf/source/commits/branch/main),
they are barely keeping up with upstream firefox. The maintainers have
repeatedly communicated (on matrix) they were close to burning out.
The code changes being done are mostly bumps with patch rebases,
removals of patches which no longer apply, and a lot of somewhat trivial changes.
Very few substantial changes to librewolf itself are made.
I originally switched to Librewolf when firefox expanded their enshitification efforts,
at a time where search engine policies were not possible to define with mainline firefox.
Mainline started supporting search engine policies since. While enshitification
did not slow down, librewolf does not keep up sufficiently to combat that effectively.
I appreciate the project for what it does and tries to do.
But i no longer believe the project is sustainable.
Not in nixpkgs, and probably not upstream either.
Well, what now? I am not the last maintainer of librewolf source package.
I am hoping someone else will step up, and maybe start actually committing open PRs too.
Personally, i will be moving back to mainline firefox, and apply [Phoenix](https://github.com/celenityy/Phoenix).
Phoenix has a nice flake, and does not require a browser recompile for the changes it does.
Phoenix does many of the things librewolf does, while imposing less of a maintainance burden.
I wish the best of luck to all remaining librewolf maintainers.
Follow-up to 7cf5972410
While the JS script already returned early, we can save a few resources
by skipping the job entirely when there's no `pull_request` context.
This is an experiment and can be reverted a few days from now; if
the results are positive on GitHub’s end, then we may want to make
the merge conflict checks run less frequently than the rest of the
labelling tasks.
PRs which add packages to the mpvScripts scope today have a
difficult time finding qualified reviewers and often sit
idle/unnoticed for months. using the ci/OWNERS tooling here
ought to help more of those PRs to not fall through the cracks.
Limine is actively and well maintained upstream, and I'm very happy I
could get that effort started in 2024. Since I'm no longer focusing on
Limine, I'm stepping back from maintaining this package.
Thanks to the upstream maintainers for their continued work. I'll
remain an active nixpkgs contributor in areas where I can provide
meaningful input.
Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
I fixed this for the maintainer maps, but the artifact that was causing the
particular issue that prompted me to try to fix it was actually the
pagination cursor. So fix that too.
Related: #464046.
