Methodology:
- `sed` to find and replace in pkgs/*
- exclude pkgs/top-level
- nixpkgs-review on x86_64-linux and aarch64-linux
- revert everything that doesn't build
- revert everything that doesn't launch [x86_64-linux]
- check upstream source whether the change makes sense [free software only]
* set pname rather than name in the generateEclipse function
* use the standard 'version' attribute name rather than the ad-hoc
'productVersion' attribute when calling buildEclipseUnversioned
* pass 'pname' and 'version' through to mkDerivation, and let it
derive 'name', per standard convention
* update generation of the '-configuration' argument to use 'version'
fixes:
The derivation has no version attribute, so do not know how to figure out the version while doing an updateScript update
... during automated update process introduced in 5bb31f9518
this is a relatively simple recasting of the existing update script,
using the "object addition" feature of 'jq' to incrementally update
the eclipses.json document with the URL components and their hashes.
it does end up defining the same update script for every eclipse
packaging, but in local testing, maintainers/scripts/update.nix seems
smart enough to realize it should only run that script once.
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev b32a094368
result/bin/apply-formatting $NIXPKGS_PATH
sed -i 's/ webkitgtk\b/ webkitgtk_4_0/g' pkgs/**.nix
sed -i 's/(webkitgtk\b/(webkitgtk_4_0/g' pkgs/**.nix
sed -i 's/\.webkitgtk\b/.webkitgtk_4_0/g' pkgs/**.nix
webkitgtk is currently pointing to that specific ABI version but the
alias is going to start warning
* generalize the justj-stripping regex a tad, since it has grown a
trailing /java in some flavors of eclipse.
* resurrect .eclipseproduct workaround from 2012-12 /
8a7561ec09
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
in combination with the parent commit that makes jdk10 use gtk3, this
lets us get onto a current webkitgtk.
since the current version of webkitgtk is still receiving security
updates, this also reverts 49ea0e2736
"eclipse: Do not use webkitgtk2 by default".
Having `glib` in the build inputs will allow its build hook to
trigger. Also adds `gsettings_desktop_schemas` as a dependency since
Eclipse appears to need the schemas under certain circumstances.
