This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.
Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev b32a094368
result/bin/apply-formatting $NIXPKGS_PATH
Pygments package is needed by docutils to support syntax
highlighting via the ".. code::" directive.
Without pygments, the rendered pages contain errors like this:
Cannot analyze code. Pygments package not found.
Since the checkPhase runs before fixupPhase, we must manually patch
shebangs for plugins that are executed during tests.
Specifically, when docutilsSupport is enabled. The tests for the rst
plugin failed.
Since 476635afe1 ("Drop myself from meta.maintainers for most
packages.", 2021-10-14), the package is not officially maintained and
would deserve some care.
The line-continuation backslash should not be a part of optional
string because it can lead to errors like this:
/nix/store/333six1faw9bhccsx9qw5718k6b1wiq2-stdenv-linux/setup: line 90: --prefix: command not found
builder for '/nix/store/lb07r900fpg7r1555zpf0j8n1n7g3wlx-ikiwiki-3.20200202.3.drv' failed with exit code 127
IkiWiki's highlight plugin requires this.
Note that the current highlight version (3.57) is not compatible with
ikiwiki version in nixpkgs. This will be fixed in the next commit.
* pkgs: refactor needless quoting of homepage meta attribute
A lot of packages are needlessly quoting the homepage meta attribute
(about 1400, 22%), this commit refactors all of those instances.
* pkgs: Fixing some links that were wrongfully unquoted in the previous
commit
* Fixed some instances
