This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.
Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
ninja is a bit faster at building the software than make. My
measurements put it at about 20% faster.
# make
❯ nx hyperfine 'nix build .#mumble --rebuild' --warmup 1
--ignore-failure
Benchmark 1: nix build .#mumble --rebuild
Time (mean ± σ): 73.287 s ± 2.462 s [User: 0.679 s, System:
3.338 s]
Range (min … max): 69.478 s … 77.686 s 10 runs
# ninja
❯ nx hyperfine 'nix build .#mumble --rebuild' --warmup 1
--ignore-failure
Benchmark 1: nix build .#mumble --rebuild
Time (mean ± σ): 60.481 s ± 2.828 s [User: 0.089 s, System:
1.173 s]
Range (min … max): 57.687 s … 66.910 s 10 runs
This option has been removed by upstream for a long time, as nobody uses
that codec anymore.
For details see upstream 4d05018c2e4f1bda48f6244b38f1e7bdc06de808
There is no such option anymore, as unbundled opus is now the only
supported option. See upstream d11fd05062f5684b3ffb698eb4cd3130356b6e9a
for details.
Support for the speex codec has long since been removed from upstream.
See https://github.com/mumble-voip/mumble/pull/5869 for details.
the use-bundled-speex option now means to use the speex-dsp library
which is packaged separately in nix.
As a reader I first thought that this package was built using automatke,
when in fact it is built using cmake. This rename should help lessen that confusion.
Without applying the build option BUILD_NUMBER, Mumble only knows about
the major and minor version. So, if the actual version string is
1.5.735, then the Mumble application only displays 1.5.0. Fix that.
Reported-by: Hartmnt
Signed-off-by: Felix Singer <felixsinger@posteo.net>
The Poco Foundation CMake config file unconditionally searches for
utf8proc. Therefore, every package that uses this CMake config requires
utf8proc.
Remove all utf8proc dependencies that were manually added because
utf8proc was not propagated.
This reverts commit 65a333600d.
This wasn't tested for correctness with something like fodwatch [0],
and should not have been (self-)merged so quickly, especially without
further review.
It also resulted in the breakage of at least one package [1] (and that's
the one we know of and was caught).
A few packages that were updated in between this commit and this revert
were not reverted back to using `rev`, but other than that, this is a
1:1 revert.
[0]: https://codeberg.org/raphaelr/fodwatch
[1]: https://github.com/NixOS/nixpkgs/pull/396904 / 758551e458
I'm not going anywhere, I'm focusing my energy on other issues, and
getting pinged as a maintainer for packages is a bit distracting (also
I'm not using most of these packages anyways!)
The nixpkgs-unstable channel's programs.sqlite was used to identify
packages producing exactly one binary, and these automatically added
to their package definitions wherever possible.
32-bit builds fail due to the following error. Apply a patch from master
to fix the issue.
[ 25%] Building CXX object plugins/gtav/CMakeFiles/gtav.dir/gtav.cpp.o
In file included from /build/source/plugins/gtav/Game.h:9,
from /build/source/plugins/gtav/gtav.cpp:6:
/build/source/plugins/gtav/structs.h:218:37: error: static assertion failed
218 | static_assert(sizeof(CCameraAngles) == 0x408, "");
| ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/build/source/plugins/gtav/structs.h:218:37: note: the comparison reduces to '(1028 == 1032)'
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Mumble is using a deprecated OpenSSL API and this is causing problems
because OpenSSL 1.1 support should be dropped from nixpkgs. However, a
patch making Mumble compatible to the OpenSSL 3.0 API is available on
its master branch and included in the latest snapshot, but unfortunately
that snapshot is not production ready.
Apply the patch for the nixpkgs build so that we can get rid of that old
OpenSSL version and drop the specific Qt package using it.
Signed-off-by: Felix Singer <felixsinger@posteo.net>
with structuredAttrs lists will be bash arrays which cannot be exported
which will be a issue with some patches and some wrappers like cc-wrapper
this makes it clearer that NIX_CFLAGS_COMPILE must be a string as lists
in env cause a eval failure
Fixes 'static assertion failed: static_assert(sizeof(CCameraAngles) == 0x408, "");'
when compiling pkgsi686Linux.mumble, which is a dependency of x64 mumble_overlay.
Update version to 1.4.231.
Build 231 points to a specific commit from the 1.4.x branch adding many
fixes and improvements. Since this version is an unofficial release, add
an unstable prefix to the version string in Nixpkgs.
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Signed-off-by: Franz Pletz <fpletz@fnordicwalking.de>
