The CMake declarations for apache-orc expect the presence of
`PROTOBUF_HOME` in order to consider the library found, in addition to
the currently specified zstd and lz4 locations. We add it accordingly.
The test was in disabledTests, which feeds ctest --exclude-regex
and only matches ctest target names (e.g. "arrow-azurefs-test"),
not individual googletest cases. Moved it to GTEST_FILTER where
individual test names are actually filtered.
Ref: https://github.com/NixOS/nixpkgs/pull/488184
Before this change it was running into:
```
error: infinite recursion encountered
at /home/tobim/n/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:82:22:
81| # An infinite recursion here can be caused by having the attribute names of expression `e` in `.overrideAttrs(finalAttrs: previousAttrs: e)` depend on `finalAttrs`. Only the attribute values of `e` can depend on `finalAttrs`.
82| args = rattrs (args // { inherit finalPackage overrideAttrs; });
```
The tests rely on `minio` which is has been abandoned upstream, see #490996.
In order to reduce the number of packages that will be flagged as insecure
once minio is tagged with `knownVulnerabilities`, we disable the arrow-cpp
tests needing it.
- add `azurite` to `nativeInstallCheckInputs` with `enableAzure`
Fixes run of `arrow-azurefs-test`:
```
[----------] 6 tests from TestAzureFileSystemOnAllEnvs/0, where
TypeParam = arrow::fs::TestingScenario<arrow::fs::AzuriteEnv,false>
[ RUN ] TestAzureFileSystemOnAllEnvs/0.DetectHierarchicalNamespace
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:901: Failure
Value of: _st.ok()
Actual: false
Expected: true
'_error_or_value58.status()' failed with IOError: Failed to find 'azurite' in PATH
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:174 self->server_process_->SetExecutable("azurite")
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:108 AzureEnvClass::Make()
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:892 GetAzureEnv()
WARNING: Logging before InitGoogleLogging() is written to STDERR
F20251218 15:54:18.988654 140737274596864 result.cc:27] ValueOrDie
called on an error: IOError: Failed to find 'azurite' in PATH
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:174 self->server_process_->SetExecutable("azurite")
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:108 AzureEnvClass::Make()
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:892 GetAzureEnv()
*** Check failure stack trace: ***
/build/source/cpp/build/src/arrow/filesystem
...
The following tests FAILED:
76 - arrow-azurefs-test (Failed) arrow-tests filesystem unittest
Errors while running CTest
```
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev 78e9caf153
result/bin/apply-formatting $NIXPKGS_PATH
In preparation for the deprecation of `stdenv.isX`.
These shorthands are not conducive to cross-compilation because they
hide the platforms.
Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way
One example of why this is bad and especially affects compiler packages
https://www.github.com/NixOS/nixpkgs/pull/343059
There are too many files to go through manually but a treewide should
get users thinking when they see a `hostPlatform.isX` in a place where it
doesn't make sense.
```
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is"
fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is"
```
