b4 ships editor helpers (Vim/Emacs syntax highlighting for the `b4
review` reply editor) and an `agent-reviewer.md` prompt under `misc/` in
its source tree, but these files are absent from the PyPI sdist the
package is built from. Fetch the matching git tag and expose it as
`passthru.src-misc` so downstream consumers (starting with the
`b4-review-vim` plugin) can reuse it instead of each fetching the
repository themselves. Pinning `rev` to `v${version}` keeps it in sync
with the packaged version.
Assisted-by: Claude Code (Claude Opus 4.8)
The new (experimental) TUI-based patch review workflow has this
additional dependency.
https://b4.docs.kernel.org/en/latest/maintainer/review.html#review-tui-based-patch-review-workflow-alpha
Note that for the pip packaging this is an optional dependency, if you
run b4 without it the rest of the functionality will work and when you
run `b4 review tui` it prints:
```
The TUI requires the textual library.
Install it with: pip install b4[tui]
```
So this could potentially be implemented as a separate package called `b4-tui`,
but I don't really see much benefit to that.
<LeftMouse>
This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.
Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev b32a094368
result/bin/apply-formatting $NIXPKGS_PATH
We are migrating packages that meet below requirements:
1. using `callPackage`
2. called path is a directory
3. overriding set is empty (`{ }`)
4. not containing path expressions other than relative path (to
makenixpkgs-vet happy)
5. not referenced by nix files outside of the directory, other
than`pkgs/top-level/all-packages.nix`
6. not referencing nix files outside of the directory
7. not referencing `default.nix` (since it's changed to `package.nix`)
8. `outPath` doesn't change after migration
The tool is here: https://github.com/Aleksanaa/by-name-migrate.
