I do not have the time or energy to handle all of this. Let alone my
GitHub notifications. This PR is in good faith and does not refer to
anything community-related. I will keep on doing nixpkgs work but the
pile of shame (let's call it that) needs to be cleaned. Thanks to
@mweinelt which whom I had a discussion and who made me aware of this
issue.
Cider has so far been following a semantic versioning, but the latest
hotfix release (v4.0.9.1) obliges us to consider a fourth segment in the
version to prevent the update bot from returning the package to its non
hotfixed version.
Appends libGL's lib/ directory to the application libraries' RPATH
instead of exporting it in LD_LIBRARY_PATH.
The only reason for us to have libGL as a dependency in Cider is because
ANGLE dlopen's it in the --type=gpu-process subprocess spawned by the
main Cider application.
The LD_LIBRARY_PATH approach works, but it is leaky: those paths are
inherited by every child process and they apply to all dlopens,
including the ones by processes Cider spawns which are unrelated to
gpu-process.
passthru.icaroot used an output placeholder outside a derivation string
context, so module consumers received an unresolved path. Define the
derivation with finalAttrs, then derive icaroot from finalPackage to
expose the actual store path.
hinst registers Citrix-mime_types.xml and the Citrix-Receiver icon via
xdg tooling; without them the application/x-ica and
application/vnd.citrix.receiver.configure types are undefined and the
desktop entries reference a missing icon. Install both into share/, and
copy only *.desktop into share/applications so the MIME XML no longer
lands there.
hinst writes an FHS wfica.sh launcher even on non-root installs; it
hardcodes /opt/Citrix paths and carries none of the wrapper environment,
so it is dead weight in the store.