This change makes ecwolf.meta.description one of the ECWolf project’s
official descriptions more closely. The official description was taken
from the first sentence of this page [1] and tweaked to follow Nixpkgs’s
rules for meta.description values [2].
[1]: <https://maniacsvault.net/ecwolf>
[2]: pkgs/README.md
2f530fd78e removed all uses of fetchpatch
from pkgs/by-name/ec/ecwolf/package.nix but did not remove fetchpatch
from the function’s parameter list. This change fixes that mistake.
This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.
Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
Before this change, ecwolf.src.rev was set to the name of a tag. This is
generally not recommended. It’s better to set rev to
"refs/tags/<tag-name>" [1].
[1]: <https://nixos.org/manual/nixpkgs/stable/#fetchgit>
Before this change, the ecwolf package used a recursive attribute set.
In general, it’s recommended that you avoid using recursive attribute
sets [1]. This change makes it so that the ecwolf package uses
finalAttrs instead of a recursive attribute set. As an added bonus, this
also means that ecwolf.src.rev will automatically get updated if someone
calls ecwolf.overrideAttrs and overrides ecwolf.version.
[1]: <https://nix.dev/guides/best-practices.html#recursive-attribute-set-rec>
Co-authored-by: Jason Yundt <jason@jasonyundt.email>
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev b32a094368
result/bin/apply-formatting $NIXPKGS_PATH
We are migrating packages that meet below requirements:
1. using `callPackage`
2. called path is a directory
3. overriding set is empty (`{ }`)
4. not containing path expressions other than relative path (to
makenixpkgs-vet happy)
5. not referenced by nix files outside of the directory, other
than`pkgs/top-level/all-packages.nix`
6. not referencing nix files outside of the directory
7. not referencing `default.nix` (since it's changed to `package.nix`)
8. `outPath` doesn't change after migration
The tool is here: https://github.com/Aleksanaa/by-name-migrate.
