This elfutils commit:
30b5592a34
moved the pkg-config check to the top level, causing the build to fail
with debuginfod disabled. Fix it by making our pkg-config depdendency
unconditional.
This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.
Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
`elfutils` has a `stack` binary built in `src`.
When built in source tree this breaks when `#include <stack>` is
transitively included in
`libc++` via `<iostream>`.
The trigger set of options is `-I $(srcdir)` which turns to `-I .` with
`./stack` present.
The fix turns the above to `-I ../src` without `./stack` present.
The change is conditional on `LLVM` to avoid `stdenv` rebuild. We will
turn it into unconditional in `staging` once this gets merged.
While at it dropped `CFLAGS` / `CXXFLAGS` overrides.
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev 78e9caf153
result/bin/apply-formatting $NIXPKGS_PATH
We are migrating packages that meet below requirements:
1. using `callPackage`
2. called path is a directory
3. overriding set is empty (`{ }`)
4. not containing path expressions other than relative path (to
makenixpkgs-vet happy)
5. not referenced by nix files outside of the directory, other
than`pkgs/top-level/all-packages.nix`
6. not referencing nix files outside of the directory
7. not referencing `default.nix` (since it's changed to `package.nix`)
8. `outPath` doesn't change after migration
The tool is here: https://github.com/Aleksanaa/by-name-migrate.
