This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.
Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
I cherry-picked the commits from https://github.com/NixOS/nixpkgs/pull/330581
and then added the 1.5.1 update on top.
We can drop the darwin patch since the affected code is only present in
the tests and those don't work on darwin anyway, so we can better just
don't compile them at all on that platform.
On Linux we do compile and now also run the tests.
Release notes for 1.4.0 state that Promontory chipsets are unsupported,
and that attempting to read flash on those systems may crash the system.
The patch that removes this (broken) support only made it into the
1.3.0 release, seemingly by mistake, and the relevant code has been
essentially untouched since.
We'd rather not crash the systems of unsuspecting NixOS/nixpkgs users,
so this change forward-ports the patch from 1.3.0, though amended to
reference the relevant bug in the error message, rather than requesting
the user email upstream.
Link: https://ticket.coreboot.org/issues/370
Link: https://review.coreboot.org/c/flashrom/+/68824
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev b32a094368
result/bin/apply-formatting $NIXPKGS_PATH
We are migrating packages that meet below requirements:
1. using `callPackage`
2. called path is a directory
3. overriding set is empty (`{ }`)
4. not containing path expressions other than relative path (to
makenixpkgs-vet happy)
5. not referenced by nix files outside of the directory, other
than`pkgs/top-level/all-packages.nix`
6. not referencing nix files outside of the directory
7. not referencing `default.nix` (since it's changed to `package.nix`)
8. `outPath` doesn't change after migration
The tool is here: https://github.com/Aleksanaa/by-name-migrate.
