In 344a3c2437 we attempted to disable bot updates on gpclient. But it
didn't work because of a quirk in bot logic.
Re-inherit the description locally so meta.position points at gpclient
while preserving the inherited metadata text.
Precedent: fab23265d6
Assisted-by: gpt-5.5 xhigh
PR #485779 dropped the gpgui.desktop install, reasoning that all gpgui
files require the proprietary gpgui binary. But the desktop file is not
gpgui-only: its Exec is `gpclient launch-gui %u`, the free CLI subcommand
that receives the SAML auth callback. Without it the
x-scheme-handler/globalprotectcallback handler is unregistered, so
external-browser SSO (`gpclient connect --browser <x>`) hangs after login
- the browser opens globalprotectcallback://<data> with nothing to handle
it, and the auth cookie never returns to the waiting connect process.
Reinstall the desktop file on Linux and point Exec at the gpclient in
$out, matching the pre-2.5.1 behaviour.
This reverts commit 65a333600d.
This wasn't tested for correctness with something like fodwatch [0],
and should not have been (self-)merged so quickly, especially without
further review.
It also resulted in the breakage of at least one package [1] (and that's
the one we know of and was caught).
A few packages that were updated in between this commit and this revert
were not reverted back to using `rev`, but other than that, this is a
1:1 revert.
[0]: https://codeberg.org/raphaelr/fodwatch
[1]: https://github.com/NixOS/nixpkgs/pull/396904 / 758551e458
Cargo 1.84.0 seems to have changed the output format of cargo vendor
again, once again invalidating fetchCargoTarball FOD hashes. It's
time to fix this once and for all, switching across the board to
fetchCargoVendor, which is not dependent on cargo vendor's output
format.
It should be possible to reproduce this diff. To do so, get the list
of files changed by this commit, e.g. with git diff --name-only, then
run the following two commands, each with that list of files as their
standard input:
xargs sed -i 's/^\(. *\)\(cargoHash\)\b/\1useFetchCargoVendor = true;\n\1cargoHash/'
cut -d / -f 4 | xargs -n 1 nix-update --version=skip
This will take a long time. It might be possible to parallelize it
using xargs' -P option. I haven't tested it.
PR #308324 describes the various issues with using absolute paths in
desktop entries. This change makes gpclient comply with the direction
stated in that PR.
Suggested-by: @tomodachi94
Signed-off-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>
Without this, login with the non-external browser results in:
> 2024-10-10T06:15:23Z WARN gpauth::auth_window] Failed to load uri: <uri> with error: TLS/SSL support not available; install glib-networking
The login flow seems to work after adding glib-networking to
GIO_EXTRA_MODULES by wrapping the `gpclient` program.
