Applies the fixes for 1.88 regressions that have caused widespread
breakage in Nix. Currently we are building with 1.89, so only 2 fixes
are relevant [1,2], with the second patch being backported to avoid
conflicts - the issue it addresses doesn't blow up in nix - but it
does in userver and other stuff too probably.
The third patch was authored by NaN-git to unbreak nix with 1.89, so
we apply it to 1.88 (the initial version that had the fiber-specific
exception state changes with fcontext and libstdc++). This is mostly for
consistency and unbreak boost.context on that version.
[1]: https://github.com/boostorg/context/pull/337
[2]: https://github.com/boostorg/context/pull/331
This properly flattens the patches array again -
otherwise all patches are dropped when structuredAttrs are enabled.
The build will finish, but downstream users of the library will
not be able to link to it properly (e.g. folly).
This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.
Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
This is now handled by the compiler wrapper.
I have verified that `webkitgtk_6_0` still has no GCC dependency on
`aarch64-linux`, and that `watchman` doesn’t pull in any `dev`
outputs on `aarch64-darwin`.
Closes: #424844Closes: #426934Closes: #427475Closes: #428546
The `expat` was removed upstream in 10135eeab5f7cd28e43f00699dea724231cd7556 [1].
Boost used SVN at the time making precise timeline checks bothersome,
but it seems the first release including this drop was in late 2010.
Nixpkgs had the expat include logic in 00b296762a for version 1.43.
We no longer maintain such ancient versions of boost, yet the logic was still there.
[1] 10135eeab5
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev 78e9caf153
result/bin/apply-formatting $NIXPKGS_PATH
In preparation for the deprecation of `stdenv.isX`.
These shorthands are not conducive to cross-compilation because they
hide the platforms.
Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way
One example of why this is bad and especially affects compiler packages
https://www.github.com/NixOS/nixpkgs/pull/343059
There are too many files to go through manually but a treewide should
get users thinking when they see a `hostPlatform.isX` in a place where it
doesn't make sense.
```
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is"
fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is"
```
msvcrt is only one of the libcs in MinGW. We therefore
replace explictly testing for msvcrt with the isMinGW
predicate. This lays the foundation for ucrt64 support.
