This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.
Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
this fixes an error when using `ppx_deriving` in a downstream project.
```
ocaml5.3.0-basil_lsp> File "/nix/store/x-ocaml5.3.0-ppx_deriving-6.0.3/lib/ocaml/5.3.0/site-lib/ppx_deriving/META", line 1, characters 0-0:
ocaml5.3.0-basil_lsp> Error: Library "ppxlib.ast" not found.
ocaml5.3.0-basil_lsp> -> required by library "ppx_deriving.show" in
ocaml5.3.0-basil_lsp> /nix/store/x-ocaml5.3.0-ppx_deriving-6.0.3/lib/ocaml/5.3.0/site-lib/ppx_deriving/show
```
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev b32a094368
result/bin/apply-formatting $NIXPKGS_PATH
checkInputs used to be added to nativeBuildInputs. Now we have
nativeCheckInputs to do that instead. Doing this treewide change allows
to keep hashes identical to before the introduction of
nativeCheckInputs.
To keep this for the future we also strictDeps where possible, including for janePackages, topkg, oasis and ocamlbuild.
This makes some closures significantly smaller and makes cross compilation easier
ocamlPackages.ppx_deriving_yojson: 3.5.2 → 3.6.1
ocamlPackages.visitors: 20200210 → 20210127
ocamlPackages.pgocaml: disable for OCaml < 4.08
ocamlPackages.nocrypto: disable for OCaml < 4.08
ocamlPackages.lens: mark as broken
ocamlPackages.ppx_deriving_protobuf: mark as broken
Closes#108137
