This reverts commit 65a333600d.
This wasn't tested for correctness with something like fodwatch [0],
and should not have been (self-)merged so quickly, especially without
further review.
It also resulted in the breakage of at least one package [1] (and that's
the one we know of and was caught).
A few packages that were updated in between this commit and this revert
were not reverted back to using `rev`, but other than that, this is a
1:1 revert.
[0]: https://codeberg.org/raphaelr/fodwatch
[1]: https://github.com/NixOS/nixpkgs/pull/396904 / 758551e458
These dependencies were used in example tools and projects.
The example tools and projects were never built in nix,
and were removed in the upstream 1.9.22 release [1].
This makes `readline` and `libsndfile` unused dependencies that should be cleaned up.
[1] https://github.com/jackaudio/jack2/releases/tag/v1.9.22
The eigen dependency was added in 9d0441434d to support the iio plugin.
This plugin however was never included in our libjack.
Reason is, upstream requires both eigen and gtkIOStream for iio [1].
gtkIOstream [2] is mostly unmaintained upstream
and not even packaged in nixpkgs.
This means the eigen dependency is currently effectively unused.
[1] 43e1173e30/wscript (L140-L149)
[2] https://github.com/flatmax/gtkiostream
Format all Nix files using the officially approved formatter,
making the CI check introduced in the previous commit succeed:
nix-build ci -A fmt.check
This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153)
of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166).
This commit will lead to merge conflicts for a number of PRs,
up to an estimated ~1100 (~33%) among the PRs with activity in the past 2
months, but that should be lower than what it would be without the previous
[partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537).
Merge conflicts caused by this commit can now automatically be resolved while rebasing using the
[auto-rebase script](8616af08d9/maintainers/scripts/auto-rebase).
If you run into any problems regarding any of this, please reach out to the
[formatting team](https://nixos.org/community/teams/formatting/) by
pinging @NixOS/nix-formatting.
On x86-64, the executables were looking for
libraries in `${lib.getLib stdenv.cc.cc}/lib64`,
but that path apparently changed with
5e2e98f3b7 ,
resulting in a runtime error:
> /nix/store/0z8gd4fmjknwswx0pp5kzqnrhj1k9q8x-samsung-UnifiedLinuxDriver-4.01.17/lib/cups/filter/rastertospl: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory
Affected programs are
`$out/lib/cups/filter/{ps,raster}tospl{,c}`.
The commit at hand fixes the library lookup path.
Change the name of the derivation in
`pkgs/misc/cups/drivers/samsung/4.01.17.nix` from
"samsung-UnifiedLinuxDriver" to "samsung-unified-linux-driver",
so that it matches the names of the other versions declared
in `pkgs/misc/cups/drivers/samsung/1.00.37.nix` and in
`pkgs/by-name/sa/samsung-unified-linux-driver_1_00_36/package.nix`.
