The .unwrapped attributes are not correctly spliced. Use the top
level attributes instead, which are spliced correctly.
Fixes: e9b2edb491 ("linux: un-simplify toolchain selection")
If we're going to use the unwrapped versions, we should do so
consistently in both parts of the kernel build, not mix and match.
Fixes: e9b2edb491 ("linux: un-simplify toolchain selection")
This reverts commit 94276da9e9.
Original justification[1] was:
> it reduces unnecessary code duplication and should help with cross
> compilation (although this cannot be tested yet because some
> dependencies fail).
However, as time as gone on its become increasingly clear that the
kernels make flags are going to be specific to building a kernel, not
a userspace program, hence them having been renamed to
kernelModuleMakeFlags in the meantime. This has become even more
apparent now that we're using unwrapped compilers for the kernel,
which doesn't go at all well with building a userspace program like
perf, so we stop inheriting any make flags from the kernel, and
instead just set the two flags necessary for cross compilation to
work.
Link: https://github.com/NixOS/nixpkgs/pull/34068 [1]
Fixes: e9b2edb491 ("linux: un-simplify toolchain selection")
This reverts commit 70cc251554.
This commit caused gcc to be pulled in as a target compiler for
pkgsLLVM.
Co-authored-by: Tristan Ross <tristan.ross@midstall.com>
Asserting the hostplatform for `linux` is bad, because it can't be
caught by CI. For the `linux` package itself, it doesn't make a
difference, because it also has `meta.platforms = linux` set, so this
will fail evaluation - and in a way that can nicely be caught by CI.
