This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.
Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
`asm/unaligned.h` has been moved to `linux/unaligned.h` since
Linux v. 6.12 [^1]. This has broken the build for `vendor-reset`
on newer versions.
I've opened a PR with the upstream project [^2], but that has been
sitting unmerged on GitHub for a while now, so I decided to add the
fix temporarily using `fetchpatch` in the NixOS module for now.
When it will (hopefully) eventually be merged, we should be able to
remove the patch and just switch to an up-to-date upstream version.
[^1]: 5f60d5f6bb
[^2]: https://github.com/gnif/vendor-reset/pull/86
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev b32a094368
result/bin/apply-formatting $NIXPKGS_PATH
The `vendor-reset` Linux kernel module stopped building as of kernel
versions 6.8.1 because `strlcopy` has been removed. An upstream patch
fixed this by replacing the only callsite with `strscpy` [^1].
As the patch has already been merged into `master`, I updated the
nix package to the latest trunk commit and labeled the version
as `unstable-2024-04-16`.
Since the only patch specified in the package has already been
merged in late 2022 [^2], we can remove that one as well.
[^1]: https://github.com/gnif/vendor-reset/pull/79
[^2]: https://github.com/gnif/vendor-reset/pull/58
