Those extensions don't support building with PostgreSQL 18, yet.
To make sure the broken status is updated on the next upgrade, they all
have version checks in the form of an evaluation warning, so that there
has be explicit action regarding its PG18 compatibility.
This is for consistency with postgresqlTestExtension and
postgresqlTestHook. Everything that is passed via postgresql's
generic.nix "packages scope" now is prefixed with "postgresql".
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev b32a094368
result/bin/apply-formatting $NIXPKGS_PATH
Those extensions don't support building with PostgreSQL 17, yet.
To make sure they will show up as build failures after the next package
upgrade, they all have version checks for their own package version
included.
The nixpkgs-unstable channel's programs.sqlite was used to identify
packages producing exactly one binary, and these automatically added
to their package definitions wherever possible.
This failed because libpam, which postgresql is now linked against, was missing as a
build input. In general, this is an indication that this extension needs the same
build inputs that postgresql was built with - so we just pass those instead.
This makes similar build failures less likely in the future.
Without the change the build fails as:
watch.c:673:2: error: format not a string literal and no format arguments [-Werror=format-security]
673 | mvprintw(r, context->cols - strlen(help), help);
| ^~~~~~~~
Marking packages broken isn't as fatal as throwing an exception. In my usecase,
I wanted to build all non-broken packages, that is:
```
nix-build -E 'with import ./.{}; with lib; flip filterAttrs postgresqlPackages (n: v: !v.meta.broken or false)'
```
