Commit Graph

10 Commits

Author SHA1 Message Date
Andreas Rammhold
9db1435899 tests.problems: regenerate all the test fixtures
This drops the stack trace truncated marker from all the fixtures as
those aren't reliable. What we care about is the exact error message
and not the stack traces.
2026-07-24 11:39:29 +02:00
Andreas Rammhold
717e330f8e tests.problems: only match on the error message
This drops matching on the truncated stack trace marker as that only
appears if the stack trace is actually long enough. In some cases the
stack trace is simply too short so Nix prints it out entirely. Then
the tests fail and I'm unhappy.

This was caused by a90d993610 which to the best of my understanding
forces the error message very early in the eval and thus doesn't have
a very long stack trace.
2026-07-24 11:39:29 +02:00
Andreas Rammhold
1f248f342b tests.problems: Fix invalid-kind-error failure
With 8fcbb35929 all problem kinds are
being used in the error messages. The expected messages were still
missing the `maintainerless` kind.
2026-07-13 13:39:20 +02:00
Andreas Rammhold
4aef6f76d4 tests.problems: adjust test code for oldestSupportedRelease=26.05
In 53cd6f263c the oldestSupportedRelease
version was bumped to 26.05 which caused the meta/problems tests to
fail because the `config.allowBrokenPredicate` is now deprecated and
the code is warning about it.
2026-07-13 13:38:53 +02:00
Silvan Mosberger
eba1d51352 meta.problems: Internal refactoring
Makes future changes easier
2026-06-19 18:58:10 +02:00
Eman Resu
41bafcbc34 stdenv/problems: reverse parameter order for handlerForProblem
kind and name are more likely to stay the same. Doing this allows us to
cache the kind and name when calling the handler for a problem.
2026-06-01 23:05:13 -04:00
Eman Resu
5c89ab858d stdenv/problems: only run problem if it's not ignored 2026-05-25 23:59:00 -04:00
Silvan Mosberger
2e97caa6d3 stdenv: Use meta.problems for meta.broken underneath
And add tests for it
2026-03-13 19:36:57 +01:00
Silvan Mosberger
764a7dbadf stdenv: Fix handleEvalIssue for error problems
This was an oversight in https://github.com/NixOS/nixpkgs/pull/478539
that became apparent in https://github.com/NixOS/nixpkgs/pull/494416:

If there's a failing problem in Nixpkgs packages, CI will call
handleEvalIssue on it, but the problem error was missing a `.reason`.

Though even if it did have a reason, we need to do more to make sure
we don't break any code that uses it, so the new code uses the problem
kind as the reason, which happens to match with the reason for all
expected problem kinds.
2026-03-02 14:59:30 +01:00
Silvan Mosberger
27dd434480 stdenv.mkDerivation: Initial RFC 127 implementation
See https://github.com/NixOS/rfcs/blob/master/rfcs/0127-issues-warnings.md

Co-Authored-By: piegames <git@piegames.de>
Co-Authored-By: AkechiShiro <14914796+AkechiShiro@users.noreply.github.com>
2026-02-26 14:53:30 +01:00