Commit Graph

117 Commits

Author SHA1 Message Date
Guillaume Girol
815ec0c6f2 nodejs: fix build on 32 bit platforms
this test is failing on both armv7 and i686 and is related to year 2038
issue so it probably affects all 32 bit platforms
2024-11-09 12:00:00 +00:00
Randy Eckenrode
887a9ba50a nodejs: suppress failing test on x86_64-darwin 2024-10-06 09:49:21 -04:00
Antoine du Hamel
e005e5d99f nodejs: add missing patches and skip some TLS tests on 20.x and 18.x
Co-authored-by: Fabián Heredia Montiel <fabianhjr@protonmail.com>
2024-09-26 00:00:56 +02:00
Antoine du Hamel
59777cc547 nodejs: fix tests for OpenSSL 3.2 2024-09-22 21:26:13 +02:00
Emily
64efdfcc37 nodejs: disable failing network tests (#343541) 2024-09-21 21:01:48 +01:00
Fabián Heredia Montiel
b37957f41e nodejs: disable failing network tests
https://hydra.nixos.org/build/273305124/nixlog/1
2024-09-21 11:19:06 -06:00
Maximilian Bosch
efbf70d52c nodejs: fix libv8 object files list (#337360) 2024-09-02 07:53:39 +02:00
Ivan Trubach
b3dd92e213 nodejs: fix libv8 object files list 2024-08-26 14:00:40 +03:00
Emily
24536bf02c nodejs: suppress Python warnings on x86_64-darwin 2024-08-26 07:00:03 +01:00
Antoine du Hamel
f5846d25a1 nodejs: skip tests failing in sandbox in all platforms
ce685a8422 added list of tests failing on sandbox, but for some reason
only for Darwin. We should skip those tests on all platforms otherwise
OfBorg builds are failing.
2024-08-12 15:41:37 +02:00
Ivan Trubach
31d238110c nodejs: disable failing tests on x86_64-darwin 2024-08-10 10:48:23 +03:00
Ivan Trubach
d7f46fbb5c nodejs: fix tests and disable parallel checking 2024-07-28 23:35:43 +03:00
Ivan Trubach
3cf3f6ae23 nodejs: allow building for vfpv2 2024-07-26 11:00:33 +03:00
Ivan Trubach
d162d8e50d nodejs: use ninja for build
This change cleans up build inputs and adjusts the build to use ninja.
2024-07-26 11:00:31 +03:00
Karel Kočí
e5906ddfd4 nodejs: fix cross compilation for armv7l
The v8 library supports only limited number of build platforms based on
the host architecture. The rule there is the bitness (the mixing of
32bit and 64bit architectures seems to be in most cases disallowed).
Thus this adds usage of the emulator of the host platform and builds
tools for that.

Co-authored-by: Ivan Trubach <mr.trubach@icloud.com>
2024-07-26 10:59:32 +03:00
github-actions[bot]
2567b049bd Merge master into staging-next 2024-07-25 18:00:59 +00:00
Doron Behar
2c36071c2d Merge pull request #329662 from bryango/nodejs-finalpackage
nodejs: use .finalPackage for ease of overriding
2024-07-25 16:07:22 +03:00
github-actions[bot]
7208220b63 Merge master into staging-next 2024-07-24 18:01:18 +00:00
Bryan Lai
ee9a623f89 nodejs: use .finalPackage for ease of overriding
Previously, the nodejs `passthru.pkgs` attribute refers to the package
fixed point derived in the current context, without considering
potential overrides to the main nodejs package.

This is fixed here with the `.finalPackage` attribute, which refers to
the final package fixed point, after potential overrides.

For example, previously, after overriding nodejs with `nodejs.override`,
`nodejs.pkgs` would still refer to the original package, instead of the
overridden one. After this fix, `nodejs.pkgs` would be correctly based
on the overridden `nodejs` package.
2024-07-24 22:09:15 +08:00
Ivan Trubach
90fbf71333 treewide: remove maintainer goibhniu
Inactive in Nixpkgs since 2018 (and a single PR in 2022).
https://github.com/NixOS/nixpkgs/issues?q=author%3Acillianderoiste
2024-07-24 13:38:22 +03:00
Martin Weinelt
176a56c40f Merge remote-tracking branch 'origin/staging-next' into staging
Conflicts:
- pkgs/applications/misc/blender/default.nix
- pkgs/development/web/nodejs/nodejs.nix
2024-07-11 01:06:28 +02:00
Emily
d25d9b6a2d nodejs: disable JS test suite on Darwin
This was recently enabled in #313982. It seems to be much too flaky
on Darwin currently, especially x86; see:

* <https://hydra.nixos.org/build/264860513/nixlog/8>
* <https://hydra.nixos.org/build/264956149/nixlog/3>
* <https://hydra.nixos.org/build/265094929/nixlog/3>
* <https://hydra.nixos.org/build/264901296/nixlog/3>

Disable these tests on macOS for now as the broken Node.js package
is holding up a lot of builds.

Fixes: b26563aae2
2024-07-09 14:27:05 +01:00
Ivan Trubach
97240ea0ac nodejs: add testVersion to passthru.tests 2024-07-06 18:32:37 +03:00
Ivan Trubach
ce685a8422 nodejs: fix sandboxed build on darwin 2024-07-06 18:32:36 +03:00
Pol Dellaiera
3dd6684936 Merge pull request #322799 from tie/nodejs-fix-impure-configure
nodejs: fix impure configure phase
2024-07-05 11:33:05 +02:00
github-actions[bot]
9cede82051 Merge master into staging-next 2024-07-04 12:01:10 +00:00
Anderson Torres
10e11b9615 nodejs: remove cko from maintainers
Since theey is not active anymore.
2024-07-04 01:00:41 +02:00
Ivan Trubach
f2f7ea87e8 nodejs: fix impure configure phase
When running configurePhase from impure build environment (i.e. nix
develop), default ./configure script was selecting wrong, impure Python
installation.
d57af10d1b/configure (L7-L15)
2024-06-30 09:54:32 +03:00
superherointj
f8d01a8da3 nodejs: add bash shell completion
Fixes #316507
2024-06-02 17:24:18 -03:00
Linus Heckemann
7c6316456a Merge pull request #313982 from aduh95/nodejs-jstest
nodejs: run JS test suite as part of the checks
2024-05-31 17:34:33 +02:00
Antoine du Hamel
b26563aae2 nodejs: run JS test suite as part of the checks 2024-05-29 19:26:08 +02:00
Antoine du Hamel
d2cac0ee1b maintainers: add aduh95 2024-05-29 16:09:02 +02:00
Tobias Pflug
be5f1347c7 Remove 'gilligan' as maintainer 2024-04-28 20:54:02 +02:00
Mario Rodas
2becf6e837 maintainers: drop marsam 2024-04-24 04:20:00 +00:00
Randy Eckenrode
cf1128c17a nodejs: clang 16 compatibility for x86_64-darwin
Make aligned allocations work on x86_64-darwin by ensuring libc++ uses
`posix_memalign` instead of `aligned_alloc`, which was added in 10.15.
2023-10-19 15:22:51 -04:00
Sophie Tauchert
45fa4a8863 nodejs: use system ca certificate store 2023-09-27 00:14:23 +02:00
Ivan Trubach
65ff987f80 nodejs: set strictDeps and patch bash shebangs 2023-08-28 12:16:30 +03:00
Ivan Trubach
e4d6d1b05b nodejs: cross-compile with icu 2023-08-28 12:16:30 +03:00
Ivan Trubach
d9dc4b0a07 nodejs: patch shebangs for shell scripts when cross-compiling 2023-08-28 12:16:30 +03:00
Ivan Trubach
c66389c6e1 nodejs: remove no-op postPatch phase
tr1/type_traits replacement is only relevent for Node.js v6 that’s
reached EOL in 2019.
2023-08-28 12:16:30 +03:00
Ivan Trubach
608c96eefc nodejs: run a subset of test suite 2023-08-28 12:16:30 +03:00
Ivan Trubach
51d74ca18f nodejs: mark as broken when cross-compiling for different OS 2023-08-28 12:16:30 +03:00
Ivan Trubach
f6b56c9136 nodejs: install shell completions and man pages when cross-compiling 2023-08-28 12:16:30 +03:00
Ivan Trubach
80e825ede8 nodejs: do not run patchShebangs with build inputs 2023-08-28 12:16:30 +03:00
Ivan Trubach
deb5cc6dc8 nodejs: do not pass --without-snapshot
Building --without-snapshot is no longer possible since v14. See
0822bfaa9f
2023-08-28 12:16:30 +03:00
Randy Eckenrode
87478fdfdf nodejs: use a response file with llvm-ar
nodejs produces a static archive in its `postInstall`. It detects if the
`ar` is GNU ar and uses a response file. Otherwise, it adds the files
individually. This is apparently very slow with `llvm-ar`, which Darwin
now uses by default. Fortunately, `llvm-ar` also supports response
files, so detect whether the `ar` is `llvm-ar` and use a response file.

I tested the build on aarch64-darwin. `postInstall` took less than a
minute to generate a 59 MiB static archive. Comparing to the build on
master, the only difference between the two archives is `llvm-ar` zeroes
out the dates, uids, and gids by default. Compared disassembly of the
archives appeared identical.

This fixes the timeouts on staging-next. #241951

https://hydra.nixos.org/build/227170390
2023-07-15 10:58:26 -06:00
Cheng Shao
204136bd95 nodejs: add -licuuc to libv8 pkg-config file
-licuuc is required when linking against libv8 output of nodejs.
2023-05-30 09:37:53 +00:00
ajs124
f68ae132f8 nodejs_16: also mark EOL
because it will reach its EOL 2023-09-11, before the EOL of NixOS 23.05
2023-05-08 13:35:13 +02:00
ajs124
f75ad820a1 nodejs_14: is EOL on 2023-04-30 2023-05-04 16:30:11 +02:00
Sergei Trofimovich
5eea756074 nodejs: explicitly disable __contentAddressed
Without the change attempt to enable content addressing on nodejs
breaks the `nodejs` binary:

    $ nix build -f. nodejs --arg config '{ contentAddressedByDefault = true; }'
    $ LANG=C ./result/bin/node
    #
    # Fatal error in , line 0
    # Check failed: VerifyChecksum(blob).
    #
    #
    #
    #FailureMessage Object: 0x7ffce2820790
     1: 0xb2a2c5  [./result/bin/node]
     2: 0x1866d9a V8_Fatal(char const*, ...) [./result/bin/node]
     3: 0x12d7473 v8::internal::Snapshot::Initialize(v8::internal::Isolate*) [./result/bin/node]
     4: 0xce85e6 v8::Isolate::Initialize(v8::Isolate*, v8::Isolate::CreateParams const&) [./result/bin/node]
     5: 0x9e0614 node::NewIsolate(v8::Isolate::CreateParams*, uv_loop_s*, node::MultiIsolatePlatform*, bool) [./result/bin/node]
     6: 0xafdcb2 node::NodeMainInstance::NodeMainInstance(node::SnapshotData const*, uv_loop_s*, node::MultiIsolatePlatform*, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) [./result/bin/node]
     7: 0xa670a3 node::LoadSnapshotDataAndRun(node::SnapshotData const**, node::InitializationResult const*) [./result/bin/node]
     8: 0xa6ac9c node::Start(int, char**) [./result/bin/node]
     9: 0x7f2b7002924e  [/nix/store/h9w6fix9k2lrbc05p4a6inw2r9sywlb1-glibc-2.35-224/lib/libc.so.6]
    10: 0x7f2b70029309 __libc_start_main [/nix/store/h9w6fix9k2lrbc05p4a6inw2r9sywlb1-glibc-2.35-224/lib/libc.so.6]
    11: 0x9da7f5 _start [./result/bin/node]
    Trace/breakpoint trap (core dumped)

Let's override the default by always disable content addressing.
2023-04-08 07:54:46 +01:00