mirror of
https://github.com/NixOS/nixpkgs.git
synced 2026-06-05 21:03:40 +00:00
This service is essentially a random sleep() call that old software that is unable to properly handle modern hardware initialisation being asynchronous can use to *mostly* get by. Over the years is has caused so many issues in NixOS, like introducing long delays in the boot process[1], complete deadlocks[2] and even failures when reloading services or activating a new configuration[3]. systemd has been discouraging its use since 2011 (15 years ago!), then it officially deprecated it in 2018 and since 2020 it started to show on every boot a huge wall of text calling out all the offending services that still use it. Around 2021 we managed to fix around 15 NixOS modules[4] that were relying on systemd-udev-settle and practically ZFS[5] was the only remaining one. However, since then, people have actually started to bring it back with new services[6][7][8]. This is not acceptable. So, to prevent any more (lazy) uses of systemd-udev-settle, we stop providing the systemd-udev-settle.service unit entirely. For existing modules that unfortunately still need it, we replace it with the command `udevadm settle --timeout=180`, which is all that the service does. Hopefully this will also increase the awareness that it's bad and something to be fixed. Note: I tested this change using - `nixosTests.zfs`, - `nixosTests.ifstate`, - `nixosTests.misc`, - `nixosTests.openvswitch`, - `nixosTests.predictable-interface-names` - `nixosTests.nvidia-container-toolkit` and making sure that none of the 165 packages that provide upstream units (via the `systemd.packages` option) had a dependency on systemd-udev-settle.service. [1]: https://github.com/NixOS/nixpkgs/pull/25311 [2]: https://github.com/NixOS/nixpkgs/issues/107341 [3]: https://github.com/NixOS/nixpkgs/pull/113804 [4]: https://github.com/NixOS/nixpkgs/issues/73095 [5]: https://github.com/openzfs/zfs/issues/10891 [6]: https://github.com/NixOS/nixpkgs/pull/257525#discussion_r1442702970 [7]: https://github.com/NixOS/nixpkgs/pull/460075 [8]: https://github.com/NixOS/nixpkgs/pull/284507
167 lines
5.7 KiB
Nix
167 lines
5.7 KiB
Nix
# Miscellaneous small tests that don't warrant their own VM run.
|
|
|
|
{ lib, pkgs, ... }:
|
|
let
|
|
foo = pkgs.writeText "foo" "Hello World";
|
|
in
|
|
{
|
|
name = "misc";
|
|
|
|
nodes.machine =
|
|
{ lib, ... }:
|
|
{
|
|
swapDevices = lib.mkOverride 0 [
|
|
{
|
|
device = "/root/swapfile";
|
|
size = 128;
|
|
}
|
|
];
|
|
environment.variables.EDITOR = lib.mkOverride 0 "emacs";
|
|
systemd.tmpfiles.rules = [ "d /tmp 1777 root root 10d" ];
|
|
systemd.tmpfiles.settings."10-test"."/tmp/somefile".d = { };
|
|
virtualisation.fileSystems = {
|
|
"/tmp2" = {
|
|
fsType = "tmpfs";
|
|
options = [
|
|
"mode=1777"
|
|
"noauto"
|
|
];
|
|
};
|
|
# Tests https://discourse.nixos.org/t/how-to-make-a-derivations-executables-have-the-s-permission/8555
|
|
"/user-mount/point" = {
|
|
device = "/user-mount/source";
|
|
fsType = "none";
|
|
options = [
|
|
"bind"
|
|
"rw"
|
|
"user"
|
|
"noauto"
|
|
];
|
|
};
|
|
"/user-mount/denied-point" = {
|
|
device = "/user-mount/denied-source";
|
|
fsType = "none";
|
|
options = [
|
|
"bind"
|
|
"rw"
|
|
"noauto"
|
|
];
|
|
};
|
|
};
|
|
systemd.automounts = lib.singleton {
|
|
wantedBy = [ "multi-user.target" ];
|
|
where = "/tmp2";
|
|
};
|
|
users.users.sybil = {
|
|
isNormalUser = true;
|
|
group = "wheel";
|
|
};
|
|
users.users.alice = {
|
|
isNormalUser = true;
|
|
};
|
|
security.sudo = {
|
|
enable = true;
|
|
wheelNeedsPassword = false;
|
|
};
|
|
boot.kernel.sysctl."vm.swappiness" = 1;
|
|
boot.kernelParams = [ "vsyscall=emulate" ];
|
|
system.extraDependencies = [ foo ];
|
|
};
|
|
|
|
testScript = ''
|
|
with subtest("nixos-version"):
|
|
machine.succeed("[ `nixos-version | wc -w` = 2 ]")
|
|
|
|
with subtest("nixos-rebuild"):
|
|
assert "NixOS" in machine.succeed("nixos-rebuild --help")
|
|
|
|
with subtest("Sanity check for uid/gid assignment"):
|
|
assert "4" == machine.succeed("id -u messagebus").strip()
|
|
assert "4" == machine.succeed("id -g messagebus").strip()
|
|
assert "users:x:100:" == machine.succeed("getent group users").strip()
|
|
|
|
with subtest("Regression test for GMP aborts on QEMU."):
|
|
machine.succeed("expr 1 + 2")
|
|
|
|
with subtest("the swap file got created"):
|
|
machine.wait_for_unit("root-swapfile.swap")
|
|
machine.succeed("ls -l /root/swapfile | grep 134217728")
|
|
|
|
with subtest("whether kernel.poweroff_cmd is set"):
|
|
machine.succeed('[ -x "$(cat /proc/sys/kernel/poweroff_cmd)" ]')
|
|
|
|
with subtest("whether the io cgroupv2 controller is properly enabled"):
|
|
machine.succeed("grep -q '\\bio\\b' /sys/fs/cgroup/cgroup.controllers")
|
|
|
|
with subtest("whether we have a reboot record in wtmp"):
|
|
machine.shutdown
|
|
machine.wait_for_unit("multi-user.target")
|
|
machine.succeed("last | grep reboot >&2")
|
|
|
|
with subtest("whether we can override environment variables"):
|
|
machine.succeed('[ "$EDITOR" = emacs ]')
|
|
|
|
with subtest("whether hostname (and by extension nss_myhostname) works"):
|
|
assert "machine" == machine.succeed("hostname").strip()
|
|
assert "machine" == machine.succeed("hostname -s").strip()
|
|
|
|
with subtest("whether systemd-udevd automatically loads modules for our hardware"):
|
|
machine.succeed("udevadm settle --timeout=180")
|
|
assert "mousedev" in machine.succeed("lsmod")
|
|
|
|
with subtest("whether systemd-tmpfiles-clean works"):
|
|
machine.succeed(
|
|
"touch /tmp/foo", "systemctl start systemd-tmpfiles-clean", "[ -e /tmp/foo ]"
|
|
)
|
|
# move into the future
|
|
machine.succeed(
|
|
'date -s "@$(($(date +%s) + 1000000))"',
|
|
"systemctl start systemd-tmpfiles-clean",
|
|
)
|
|
machine.fail("[ -e /tmp/foo ]")
|
|
|
|
with subtest("whether systemd-tmpfiles settings works"):
|
|
machine.succeed("[ -e /tmp/somefile ]")
|
|
|
|
with subtest("/etc/mtab"):
|
|
assert "/proc/mounts" == machine.succeed("readlink --no-newline /etc/mtab")
|
|
|
|
with subtest("whether automounting works"):
|
|
machine.fail("grep '/tmp2 tmpfs' /proc/mounts")
|
|
machine.succeed("touch /tmp2/x")
|
|
machine.succeed("grep '/tmp2 tmpfs' /proc/mounts")
|
|
|
|
with subtest(
|
|
"Whether mounting by a user is possible with the `user` option in fstab (#95444)"
|
|
):
|
|
machine.succeed("mkdir -p /user-mount/source")
|
|
machine.succeed("touch /user-mount/source/file")
|
|
machine.succeed("chmod -R a+Xr /user-mount/source")
|
|
machine.succeed("mkdir /user-mount/point")
|
|
machine.succeed("chown alice:users /user-mount/point")
|
|
machine.succeed("su - alice -c 'mount /user-mount/point'")
|
|
machine.succeed("su - alice -c 'ls /user-mount/point/file'")
|
|
with subtest(
|
|
"Whether mounting by a user is denied without the `user` option in fstab"
|
|
):
|
|
machine.succeed("mkdir -p /user-mount/denied-source")
|
|
machine.succeed("touch /user-mount/denied-source/file")
|
|
machine.succeed("chmod -R a+Xr /user-mount/denied-source")
|
|
machine.succeed("mkdir /user-mount/denied-point")
|
|
machine.succeed("chown alice:users /user-mount/denied-point")
|
|
machine.fail("su - alice -c 'mount /user-mount/denied-point'")
|
|
|
|
with subtest("shell-vars"):
|
|
machine.succeed('[ -n "$NIX_PATH" ]')
|
|
|
|
with subtest("Test sysctl"):
|
|
machine.wait_for_unit("systemd-sysctl.service")
|
|
assert "1" == machine.succeed("sysctl -ne vm.swappiness").strip()
|
|
machine.execute("sysctl vm.swappiness=60")
|
|
assert "60" == machine.succeed("sysctl -ne vm.swappiness").strip()
|
|
|
|
with subtest("Test boot parameters"):
|
|
assert "vsyscall=emulate" in machine.succeed("cat /proc/cmdline")
|
|
'';
|
|
}
|