mirror of
https://github.com/NixOS/nixpkgs.git
synced 2026-08-27 02:34:53 +00:00
`attrListWith` re-emits every flag as an `lib.mkOrder` definition, so `argv` and `flags` share one ordering space. Unadorned flags arrived at `lib.modules.defaultOrderPriority`, the same priority as unadorned `argv`, and only landed after `argv` because the declaring module's `config` happened to be collected last. Give flags that carry no ordering property of their own a priority of 1250, between `lib.modules.defaultOrderPriority` and `lib.mkAfter`. Plain flags now provably follow plain `argv`, `lib.mkAfter` on `argv` still places trailing positional arguments after the flags, and an explicit `lib.mkOrder` on a flag is honoured verbatim, which is what interleaving a sub-command among flags needs. Also render path flag values through `pathOrStr`. `lib.cli.toCommandLine` formats values with `lib.generators.mkValueStringDefault`, which has no case for paths and aborts; coercing first yields the store path, matching `argv`. Assisted-by: Claude:claude-opus-5
230 lines
8.6 KiB
Nix
230 lines
8.6 KiB
Nix
# Non-module arguments
|
|
# These are separate from the module arguments to avoid implicit dependencies.
|
|
# This makes service modules self-contains, allowing mixing of Nixpkgs versions.
|
|
{ pkgs }:
|
|
|
|
# The module
|
|
{
|
|
lib,
|
|
config,
|
|
options,
|
|
...
|
|
}:
|
|
let
|
|
inherit (lib) mkEnableOption mkOption types;
|
|
|
|
# Paths are interpolated rather than `toString`ed on purpose: interpolation
|
|
# copies the path into the store, so the resulting argument still resolves on
|
|
# the machine that runs the service. `toString` would yield the path of the
|
|
# source tree the configuration was evaluated from, which is not there at
|
|
# runtime.
|
|
pathOrStr = types.coercedTo types.path (x: "${x}") types.str;
|
|
|
|
# `argv` and `flags` share a single `lib.mkOrder` space, so flags need a
|
|
# priority. This one sits between `lib.modules.defaultOrderPriority` (1000,
|
|
# what an unadorned `argv` definition gets) and `lib.mkAfter` (1500): plain
|
|
# flags follow plain `argv` entries, while `lib.mkAfter` on `argv` still lands
|
|
# after the flags. See the `flags` option description.
|
|
unadornedFlagPriority = 1250;
|
|
|
|
# `attrListWith` re-emits every flag wrapped in `lib.mkOrder`, using
|
|
# `lib.modules.defaultOrderPriority` for flags that carried no ordering
|
|
# property of their own. Rewrite exactly that priority; anything else is an
|
|
# explicit `lib.mkOrder` from the user and is passed through verbatim.
|
|
atFlagPriority =
|
|
def:
|
|
if def.value._type or null == "order" && def.value.priority == lib.modules.defaultOrderPriority then
|
|
def // { value = lib.mkOrder unadornedFlagPriority def.value.content; }
|
|
else
|
|
def;
|
|
in
|
|
{
|
|
# https://nixos.org/manual/nixos/unstable/#modular-services
|
|
_class = "service";
|
|
imports = [
|
|
../../modules/generic/meta-maintainers.nix
|
|
../../nixos/modules/misc/assertions.nix
|
|
(lib.modules.importApply ./config-data.nix { inherit pkgs; })
|
|
];
|
|
options = {
|
|
services = mkOption {
|
|
type = types.attrsOf (
|
|
types.submoduleWith {
|
|
modules = [
|
|
(lib.modules.importApply ./service.nix { inherit pkgs; })
|
|
];
|
|
}
|
|
);
|
|
description = ''
|
|
A collection of [modular services](https://nixos.org/manual/nixos/unstable/#modular-services) that are configured in one go.
|
|
|
|
You could consider the sub-service relationship to be an ownership relation.
|
|
It **does not** automatically create any other relationship between services (e.g. systemd slices), unless perhaps such a behavior is explicitly defined and enabled in another option.
|
|
'';
|
|
default = { };
|
|
visible = "shallow";
|
|
};
|
|
process = {
|
|
argv = mkOption {
|
|
type = types.listOf pathOrStr;
|
|
example = lib.literalExpression ''[ (lib.getExe config.package) "--nobackground" ]'';
|
|
description = ''
|
|
Command filename and arguments for starting this service.
|
|
This is a raw command-line that should not contain any shell escaping.
|
|
If expansion of environmental variables is required then use
|
|
a shell script or `importas` from `pkgs.execline`.
|
|
|
|
When `flags` are set, the arguments rendered from them are merged into
|
|
`argv`. See `flags` for how the two are ordered against each other.
|
|
'';
|
|
};
|
|
|
|
flagFormat = mkOption {
|
|
type = types.functionTo (types.attrsOf types.anything);
|
|
default = name: {
|
|
option = name;
|
|
sep = null;
|
|
explicitBool = false;
|
|
};
|
|
description = ''
|
|
Function mapping flag names to option format specs
|
|
for `lib.cli.toCommandLine`.
|
|
|
|
Receives the flag name and returns `{ option, sep, explicitBool, formatArg? }`.
|
|
'';
|
|
example = lib.literalExpression ''
|
|
name: {
|
|
option = name;
|
|
sep = "=";
|
|
explicitBool = false;
|
|
}
|
|
'';
|
|
};
|
|
|
|
flags = mkOption {
|
|
type = types.attrListWith {
|
|
elemType = types.nullOr (
|
|
types.oneOf [
|
|
types.bool
|
|
types.int
|
|
# `pathOrStr`, not `types.path`: `lib.cli.toCommandLine` renders
|
|
# values with `lib.generators.mkValueStringDefault`, which has no
|
|
# case for paths and would abort.
|
|
pathOrStr
|
|
]
|
|
);
|
|
asAttrs = true;
|
|
};
|
|
default = { };
|
|
description = ''
|
|
Flags to pass to the service process.
|
|
The key is the flag name (e.g. `"--port"`), the value is the flag value.
|
|
|
|
Each `name = value` pair is rendered via `lib.cli.toCommandLine`
|
|
using `flagFormat`.
|
|
|
|
- `null`: the flag is omitted (regardless of `flagFormat`)
|
|
- bool: rendered per `flagFormat.explicitBool`
|
|
- `explicitBool = false` (default): `true` emits the bare flag,
|
|
`false` is omitted
|
|
- `explicitBool = true`: both `true` and `false` are rendered as
|
|
explicit arguments via `flagFormat.formatArg`
|
|
- string / path / int: rendered as the option's argument, joined to the
|
|
option name per `flagFormat.sep` and stringified by
|
|
`flagFormat.formatArg`
|
|
|
|
To pass the same flag multiple times, use the list form with
|
|
repeated keys, e.g.
|
|
`[ { "--host" = "a"; } { "--host" = "b"; } ]`.
|
|
|
|
The rendered arguments are merged into `argv`, so `argv` and `flags`
|
|
share a single `lib.mkOrder` space:
|
|
|
|
- A flag with no ordering property of its own is placed at priority
|
|
1250, between `lib.modules.defaultOrderPriority` (1000, which is
|
|
what an unadorned `argv` definition gets) and `lib.mkAfter` (1500).
|
|
Plain flags therefore follow the command name and any other plain
|
|
`argv` arguments.
|
|
- `lib.mkAfter` on `argv` still lands after the flags, which is how
|
|
trailing positional arguments are expressed.
|
|
- `lib.mkOrder` on a flag is honoured verbatim against `argv`, so a
|
|
sub-command can be placed between two groups of flags.
|
|
|
|
Because 1250 is substituted for flags that carry no ordering property,
|
|
`lib.mkOrder 1000` on a flag is indistinguishable from leaving that
|
|
flag unadorned. To order a flag around plain `argv` entries, pick a
|
|
priority next to 1000, such as 999 or 1001.
|
|
'';
|
|
example = lib.literalExpression ''
|
|
{
|
|
"--port" = "8080";
|
|
"--verbose" = true;
|
|
# ordered ahead of the unadorned flags above
|
|
"--config" = lib.mkOrder 1100 "/etc/foo.conf";
|
|
}
|
|
# or, for repeated flags:
|
|
[
|
|
{ "--host" = "localhost"; }
|
|
{ "--host" = "0.0.0.0"; }
|
|
]
|
|
'';
|
|
};
|
|
|
|
reloadSignal = mkOption {
|
|
type = types.nullOr types.str;
|
|
default = null;
|
|
example = "HUP";
|
|
description = ''
|
|
Configures the reload signal to send to the service manager.
|
|
'';
|
|
};
|
|
|
|
reloadCommand = mkOption {
|
|
type = types.nullOr types.str;
|
|
default = null;
|
|
example = lib.literalExpression ''"''${pkgs.coreutils}/bin/kill -HUP $MAINPID"'';
|
|
|
|
description = ''
|
|
Command used for reloading in the underlying service manager to reload.
|
|
'';
|
|
};
|
|
};
|
|
|
|
notificationProtocol = mkOption {
|
|
type = types.submodule {
|
|
options = {
|
|
systemd = mkEnableOption "Whether the service supports systemd-notify.";
|
|
s6 = mkEnableOption "Whether the service supports s6-notify.";
|
|
};
|
|
};
|
|
description = ''
|
|
Notification protocol that this service supports with the underlying service manager.
|
|
'';
|
|
};
|
|
};
|
|
|
|
config = {
|
|
assertions = [
|
|
{
|
|
# `reloadSignal` derives `reloadCommand` at `mkDefault` priority below, so a
|
|
# conflict only exists when the user *also* set `reloadCommand` explicitly.
|
|
# An explicit (non-`mkDefault`) definition has `defaultOverridePriority`.
|
|
assertion =
|
|
!(
|
|
config.process.reloadSignal != null
|
|
&& options.process.reloadCommand.highestPrio <= lib.modules.defaultOverridePriority
|
|
);
|
|
message = "reloadSignal conflicts with reloadCommand. Please either use reloadSignal or reloadCommand.";
|
|
}
|
|
];
|
|
|
|
process.reloadCommand = lib.mkIf (config.process.reloadSignal != null) (
|
|
lib.mkDefault "${pkgs.coreutils}/bin/kill -${config.process.reloadSignal} $MAINPID"
|
|
);
|
|
|
|
process.argv = lib.modules.mapDefinitionValue (
|
|
attr: lib.cli.toCommandLine config.process.flagFormat attr
|
|
) (lib.mkMerge (map atFlagPriority options.process.flags.valueMeta.definitions));
|
|
};
|
|
}
|