mirror of
https://github.com/NixOS/nixpkgs.git
synced 2026-09-02 21:54:45 +00:00
235013cf37
Scope:
- Combination of
- Textual matches of "baseNameOf (toString"
- Redundant toString calls I've found with my latest
"lazy paths" nix branch as they force lazy fetches into
the store. More info and new PR soon.
- Only cases I believe are worthwhile or easily determined
I've determined the validity by
- testing llvmPackages instantiation
- figuring out which types can pass into any particular
toString call - "human fuzzy type checker"
Behavior considerations by type:
- `path`: converted back to a string *without* context
`baseNameOf` does not copy things to the store on its own,
equivalent to its behavior for string inputs
- `null`: converted to `""` -> may be valid input!
ok if "" would not have been acceptable anyway
- `string` itself: passed through identically -> trivial
- `attrset` with `outPath`: same coercion as built into
the `baseNameOf` function -> trivial
- other atomic types: generally not sensible inputs to
`baseNameOf` -> fuzzy but true
63 lines
1.9 KiB
Nix
63 lines
1.9 KiB
Nix
{ lib, stdenvNoCC }:
|
|
/*
|
|
This is a wrapper around `substitute` in the stdenv.
|
|
|
|
Attribute arguments:
|
|
- `name` (optional): The name of the resulting derivation
|
|
- `src`: The path to the file to substitute
|
|
- `substitutions`: The list of substitution arguments to pass
|
|
See https://nixos.org/manual/nixpkgs/stable/#fun-substitute
|
|
- `replacements`: Deprecated version of `substitutions`
|
|
that doesn't support spaces in arguments.
|
|
|
|
Example:
|
|
|
|
```nix
|
|
{ substitute }:
|
|
substitute {
|
|
src = ./greeting.txt;
|
|
substitutions = [
|
|
"--replace"
|
|
"world"
|
|
"paul"
|
|
];
|
|
}
|
|
```
|
|
|
|
See ../../test/substitute for tests
|
|
*/
|
|
args:
|
|
|
|
let
|
|
name = args.name or (baseNameOf args.src);
|
|
deprecationReplacement = lib.pipe args.replacements [
|
|
lib.toList
|
|
(map (lib.splitString " "))
|
|
lib.concatLists
|
|
(lib.concatMapStringsSep " " lib.strings.escapeNixString)
|
|
];
|
|
optionalDeprecationWarning =
|
|
# substitutions is only available starting 24.05.
|
|
# TODO: Remove support for replacements sometime after the next release
|
|
lib.warnIf (args ? replacements && lib.oldestSupportedReleaseIsAtLeast 2405) ''
|
|
pkgs.substitute: For "${name}", `replacements` is used, which is deprecated since it doesn't support arguments with spaces. Use `substitutions` instead:
|
|
substitutions = [ ${deprecationReplacement} ];'';
|
|
in
|
|
optionalDeprecationWarning stdenvNoCC.mkDerivation (
|
|
{
|
|
inherit name;
|
|
builder = ./substitute.sh;
|
|
inherit (args) src;
|
|
preferLocalBuild = true;
|
|
allowSubstitutes = false;
|
|
}
|
|
// args
|
|
// lib.optionalAttrs (args ? substitutions) {
|
|
substitutions =
|
|
assert
|
|
lib.isList args.substitutions
|
|
|| throw ''pkgs.substitute: For "${name}", `substitutions` is passed, which is expected to be a list, but it's a ${builtins.typeOf args.substitutions} instead.'';
|
|
lib.escapeShellArgs args.substitutions;
|
|
}
|
|
)
|