Use the shared helper to preserve argument boundaries in ExecStart, including embedded newlines. Keep legacy strings and Darwin behavior unchanged, and cover the newline case in a Linux regression test.
Splitting the string on spaces broke arguments that legitimately contain
one, such as `--keep-since=1 day`. Accept a list of strings alongside the
string instead, each element being one argument, and restore the previous
behaviour for strings on both platforms: command line text that systemd
splits on Linux, a single argument on Darwin.
Darwin users passing several flags in one string have to switch to a list
to work around the launchd quoting.
On Linux the arguments are only appended when non-empty, which drops a
trailing space from ExecStart.
On darwin, clean.extraArgs was appended to ProgramArguments as a single
list element, so the launchd module rendered it as one shell-quoted word
and nh received every flag as a single argument:
nh clean user '--keep 5 --keep-since 3d'
error: unexpected argument '--keep 5 --keep-since 3d' found
Linux is unaffected: there extraArgs is interpolated into ExecStart as
text, and systemd splits that into arguments itself. Split on spaces so
both platforms treat the option the same way, dropping empty fields so
that an unset or space-padded value contributes no arguments.
The existing darwin test never set extraArgs, which is why this went
unnoticed. Add a case covering the option's own documented example.
User-domain agents are not rediscovered from the user LaunchAgents directory after reboot. Let built-in agents inherit the GUI default while keeping explicit user-domain configuration available.
User-domain agents need the Background session type to bootstrap into user/501, and activation should fail rather than silently unloading services when launchctl bootstrap fails.
On Darwin, launchd may attempt to start agents before the Nix store is
mounted and available. This leads to failures when the agent's executable
or arguments reside in the Nix store.
This change wraps the agent's command in a shell script that uses
/bin/wait4path to ensure /nix/store is ready before executing the
original program. It also ensures that ProgramArguments are correctly
escaped and concatenated.
