[Backport staging-26.05] coreutils: security patches (#546205)

This commit is contained in:
Vladimír Čunát
2026-08-01 08:13:52 +00:00
committed by GitHub
3 changed files with 107 additions and 0 deletions

View File

@@ -0,0 +1,45 @@
From d64e35a8a4c0e4608321433e0d84d917e4e36371 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Tue, 28 Apr 2026 11:25:00 -0700
Subject: [PATCH] uniq: fix read overrun with -w
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Problem reported by Michał Majchrowicz.
* src/uniq.c (find_field): Fix typo.
* tests/uniq/uniq.pl (add_z_variants): Test for the bug.
---
src/uniq.c | 4 ++--
tests/uniq/uniq.pl | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/uniq.c b/src/uniq.c
index 30463598a5..5834596f98 100644
--- a/src/uniq.c
+++ b/src/uniq.c
@@ -285,8 +285,8 @@ find_field (struct linebuffer const *line, idx_t *plen)
else
{
char *ep = lp;
- for (idx_t i = check_chars; 0 < i && lp < lim; i--)
- ep += mcel_scan (lp, lim).len;
+ for (idx_t i = check_chars; 0 < i && ep < lim; i--)
+ ep += mcel_scan (ep, lim).len;
len = ep - lp;
}
diff --git a/tests/uniq/uniq.pl b/tests/uniq/uniq.pl
index b558fb3ee2..0df7ec62d7 100755
--- a/tests/uniq/uniq.pl
+++ b/tests/uniq/uniq.pl
@@ -234,6 +234,9 @@ ($)
" - 'separate'\n" .
" - 'both'\n" .
"Try '$prog --help' for more information.\n"}],
+ # Test for read buffer overrun.
+ do { my $longline = "\360\237\230\200" . "A" x 255 . "\n";
+ ['146', '-w256', {IN => $longline x 2}, {OUT => $longline}] },
);
# Locale related tests

View File

@@ -0,0 +1,57 @@
From b60a159fdc5bfcf9988d3a4cb6f53abe8ad5d35d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C3=A1draig=20Brady?= <P@draigBrady.com>
Date: Tue, 28 Apr 2026 20:33:10 +0100
Subject: [PATCH] unexpand: fix heap overflow
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* src/unexpand.c (unexpand): Use xinmalloc() to gracefully
handle overflow. Also use the runtime locale specific MB_CUR_MAX
rather than the worst case MB_LEN_MAX.
* tests/unexpand/mb.sh: Add a test case that fails in a default
glibc build with either MB_CUR_MAX or MB_LEN_MAX.
* NEWS: Mention the bug fix.
Reported by Michał Majchrowicz.
---
src/unexpand.c | 2 +-
tests/unexpand/mb.sh | 8 ++++++++
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/unexpand.c b/src/unexpand.c
index 3cbff1b129..c859c17a3e 100644
--- a/src/unexpand.c
+++ b/src/unexpand.c
@@ -131,7 +131,7 @@ unexpand (void)
/* The worst case is a non-blank character, then one blank, then a
tab stop, then MAX_COLUMN_WIDTH - 1 blanks, then a non-blank; so
allocate MAX_COLUMN_WIDTH bytes to store the blanks. */
- pending_blank = ximalloc (max_column_width * sizeof (char) * MB_LEN_MAX);
+ pending_blank = xinmalloc (max_column_width, MB_CUR_MAX);
while (true)
{
diff --git a/tests/unexpand/mb.sh b/tests/unexpand/mb.sh
index 76a2679035..076a1c1ae5 100755
--- a/tests/unexpand/mb.sh
+++ b/tests/unexpand/mb.sh
@@ -17,6 +17,7 @@
. "${srcdir=.}/tests/init.sh"; path_prepend_ ./src
print_ver_ unexpand printf
+getlimits_
test "$LOCALE_FR_UTF8" != none || skip_ "French UTF-8 locale not available"
export LC_ALL="$LOCALE_FR_UTF8"
@@ -161,4 +162,11 @@ EOF
unexpand -a ./in ./in > out || fail=1
compare exp out > /dev/null 2>&1 || fail=1
+# Ensure overflow is handed gracefully
+# coreutils v9.11 induced a buffer overflow with mb_mul=4 (or 16).
+for mb_mul in 4 6; do
+ printf ' \n' | unexpand -t $(expr $SIZE_MAX / $mb_mul + 1) 2>err; ret=$?
+ test "$ret" = 1 || test "$ret" = 0 || { cat err; fail=1; }
+done
+
Exit $fail

View File

@@ -58,6 +58,11 @@ stdenv.mkDerivation (finalAttrs: {
hash = "sha256-OUAk7aCllVIXztqc0SAeZdyPo6opwpURNaSVIdV8PMM=";
};
patches = [
./CVE-2026-56391.patch
./CVE-2026-56392.patch
];
postPatch = ''
# The test tends to fail on btrfs, f2fs and maybe other unusual filesystems.
sed '2i echo Skipping dd sparse test && exit 77' -i ./tests/dd/sparse.sh