nathan/nixpkgs
1
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2026-09-30 11:50:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

[19.09] backport #71851 handbrake: fix missing audio

Browse Source 
We build HandBrake with a newer ffmpeg than upstream expects,
triggering a problem where the audio samplerate defaults to zero
because HandBrake was not explicitly setting it.

This has been fixed in HandBrake upstream, but we must cherry pick
this change in order to produce videos with audio until HandBrake
1.3.0 is released.

(cherry picked from commit d51e366ffe)
This commit is contained in:
Anthony Cowley
2019-10-23 15:33:08 -04:00
committed by Bjørn Forsman
parent 108021d6e1
commit 82efd775e3
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pkgs/applications/video/handbrake/default.nix
View File

@@ -3,7 +3,7 @@
# Derivation patches HandBrake to use Nix closure dependencies.
#
{ stdenv, lib, fetchurl,
{ stdenv, lib, fetchurl, fetchpatch,
# Main build tools
python2, pkgconfig, autoconf, automake, cmake, nasm, libtool, m4,
# Processing, video codecs, containers
@@ -61,6 +61,13 @@ stdenv.mkDerivation rec {
dontUseCmakeConfigure = true;
enableParallelBuilding = true;
# The samplerate patch should be removed when HandBrake 1.3.0 is released
patches = [(fetchpatch {
name = "set-ffmpeg-samplerate.patch";
url = "https://patch-diff.githubusercontent.com/raw/HandBrake/HandBrake/pull/2126.patch";
sha256 = "00lds9h27cvyr53qpvv8gbv01hfxdxd8gphxcwbwg8akqrvk9gbf";
})];
preConfigure = ''
patchShebangs scripts