Change default Rocq packages' name prefix (#541801)

This commit is contained in:
Vincent Laporte
2026-07-16 07:44:32 +00:00
committed by GitHub
6 changed files with 16 additions and 9 deletions

View File

@@ -59,7 +59,7 @@ The recommended way of defining a derivation for a Rocq library, is to use the `
* `releaseRev` (optional, defaults to `(v: v)`), provides a default mapping from release names to revision hashes/branch names/tags,
* `releaseArtifact` (optional, defaults to `(v: null)`), provides a default mapping from release names to artifact names (only works for github artifact for now),
* `displayVersion` (optional), provides a way to alter the computation of `name` from `pname`, by explaining how to display version numbers,
* `namePrefix` (optional, defaults to `[ "rocq-core" ]`), provides a way to alter the computation of `name` from `pname`, by explaining which dependencies must occur in `name`,
* `namePrefix` (optional, defaults to `[ "rocq" ]`), provides a way to alter the computation of `name` from `pname`, by explaining which dependencies must occur in `name`,
* `nativeBuildInputs` (optional), is a list of executables that are required to build the current derivation, in addition to the default ones (namely `which`, `dune` and `ocaml` depending on whether `useDune`, `useDuneifVersion` and `mlPlugin` are set).
* `extraNativeBuildInputs` (optional, deprecated), an additional list of derivation to add to `nativeBuildInputs`,
* `overrideNativeBuildInputs` (optional) replaces the default list of derivation to which `nativeBuildInputs` and `extraNativeBuildInputs` adds extra elements,

View File

@@ -55,7 +55,7 @@ in
extraNativeBuildInputs ? [ ],
overrideBuildInputs ? [ ],
overrideNativeBuildInputs ? [ ],
namePrefix ? [ "rocq-core" ],
namePrefix ? null,
enableParallelBuilding ? true,
extraInstallFlags ? [ ],
setROCQBIN ? true,
@@ -66,7 +66,7 @@ in
dropDerivationAttrs ? [ ],
useDuneifVersion ? (x: false),
useDune ? false,
opam-name ? (concatStringsSep "-" (namePrefix ++ [ pname ])),
opam-name ? null,
useCoq ? false,
useCoqifVersion ? (x: false),
...
@@ -160,10 +160,17 @@ let
] ""
)
+ optionalString (v == null) "-broken";
append-version = p: n: p + display-pkg n "" rocqPackages.${n}.version + "-";
prefix-name = foldl append-version "" namePrefix;
useDune = args.useDune or (useDuneifVersion fetched.version);
useCoq = args.useCoq or (useCoqifVersion fetched.version);
namePrefix = args.namePrefix or [ (if useCoq then "coq" else "rocq") ];
append-version =
p: n:
let
version = if n == "rocq" then rocqPackages.rocq-core.version else rocqPackages.${n}.version;
in
p + display-pkg n "" version + "-";
prefix-name = foldl append-version "" namePrefix;
opam-name = args.opam-name or (concatStringsSep "-" (namePrefix ++ [ pname ]));
rocq-core = if useCoq then coq // { rocq-version = coq.coq-version; } else args0.rocq-core;
rocqlib-flags = [
"COQLIBINSTALL=$(out)/lib/coq/${rocq-core.rocq-version}/user-contrib"

View File

@@ -85,7 +85,7 @@ let
;
namePrefix = [
"rocq-core"
"rocq"
"mathcomp"
];

View File

@@ -9,7 +9,7 @@
mkRocqDerivation {
namePrefix = [
"rocq-core"
"rocq"
"mathcomp"
];
pname = "bigenough";

View File

@@ -9,7 +9,7 @@
mkRocqDerivation {
namePrefix = [
"rocq-core"
"rocq"
"mathcomp"
];
pname = "finmap";

View File

@@ -10,7 +10,7 @@
mkRocqDerivation {
namePrefix = [
"rocq-core"
"rocq"
"mathcomp"
];
pname = "real-closed";