metasploit: move to pkgs/by-name, modernize (#547266)

pkgs/by-name/me/metasploit/package.nix

@@ -27,6 +27,9 @@ stdenv.mkDerivation (finalAttrs: {
     hash = "sha256-MPVgETy2JNvCPtnN/aQpBYMMPdHzQHI2dGy65kTZ5Do=";
   };
 
+  __structuredAttrs = true;
+  strictDeps = true;
+
   nativeBuildInputs = [
     makeWrapper
   ];
@@ -51,7 +54,7 @@ stdenv.mkDerivation (finalAttrs: {
   installPhase = ''
     runHook preInstall
 
-    mkdir -p $out/{bin,share/msf}
+    mkdir -p $out/share/msf
 
     cp -r * $out/share/msf
 

pkgs/tools/security/metasploit/shell.nix

@@ -1,25 +0,0 @@
-{
-  pkgs ? import ../../../.. { },
-}:
-pkgs.mkShell {
-  nativeBuildInputs = [
-    pkgs.pkg-config
-    pkgs.libffi # libffi as native input
-  ];
-  buildInputs = with pkgs; [
-    bundix
-    git
-    libiconv
-    libpcap
-    libxml2
-    libxslt
-    postgresql
-    ruby.devEnv
-    sqlite
-  ];
-  # Ensure that pkg-config finds libffi
-  shellHook = ''
-    export PKG_CONFIG_PATH="${pkgs.libffi.out}/lib/pkgconfig:$PKG_CONFIG_PATH"
-    echo "PKG_CONFIG_PATH set to: $PKG_CONFIG_PATH"
-  '';
-}

pkgs/top-level/all-packages.nix

@@ -2521,8 +2521,6 @@ with pkgs;
     docbook-xsl = docbook_xsl;
   };
 
-  metasploit = callPackage ../tools/security/metasploit { };
-
   mtr-gui = mtr.override { withGtk = true; };
 
   multitran = recurseIntoAttrs (