mirror of
https://github.com/NixOS/nixpkgs.git
synced 2026-08-27 02:34:53 +00:00
This service is essentially a random sleep() call that old software that is unable to properly handle modern hardware initialisation being asynchronous can use to *mostly* get by. Over the years is has caused so many issues in NixOS, like introducing long delays in the boot process[1], complete deadlocks[2] and even failures when reloading services or activating a new configuration[3]. systemd has been discouraging its use since 2011 (15 years ago!), then it officially deprecated it in 2018 and since 2020 it started to show on every boot a huge wall of text calling out all the offending services that still use it. Around 2021 we managed to fix around 15 NixOS modules[4] that were relying on systemd-udev-settle and practically ZFS[5] was the only remaining one. However, since then, people have actually started to bring it back with new services[6][7][8]. This is not acceptable. So, to prevent any more (lazy) uses of systemd-udev-settle, we stop providing the systemd-udev-settle.service unit entirely. For existing modules that unfortunately still need it, we replace it with the command `udevadm settle --timeout=180`, which is all that the service does. Hopefully this will also increase the awareness that it's bad and something to be fixed. Note: I tested this change using - `nixosTests.zfs`, - `nixosTests.ifstate`, - `nixosTests.misc`, - `nixosTests.openvswitch`, - `nixosTests.predictable-interface-names` - `nixosTests.nvidia-container-toolkit` and making sure that none of the 165 packages that provide upstream units (via the `systemd.packages` option) had a dependency on systemd-udev-settle.service. [1]: https://github.com/NixOS/nixpkgs/pull/25311 [2]: https://github.com/NixOS/nixpkgs/issues/107341 [3]: https://github.com/NixOS/nixpkgs/pull/113804 [4]: https://github.com/NixOS/nixpkgs/issues/73095 [5]: https://github.com/openzfs/zfs/issues/10891 [6]: https://github.com/NixOS/nixpkgs/pull/257525#discussion_r1442702970 [7]: https://github.com/NixOS/nixpkgs/pull/460075 [8]: https://github.com/NixOS/nixpkgs/pull/284507
151 lines
4.2 KiB
Nix
151 lines
4.2 KiB
Nix
# Systemd services for openvswitch
|
|
|
|
{
|
|
config,
|
|
lib,
|
|
pkgs,
|
|
...
|
|
}:
|
|
|
|
with lib;
|
|
|
|
let
|
|
cfg = config.virtualisation.vswitch;
|
|
|
|
in
|
|
{
|
|
|
|
options.virtualisation.vswitch = {
|
|
enable = mkOption {
|
|
type = types.bool;
|
|
default = false;
|
|
description = ''
|
|
Whether to enable Open vSwitch. A configuration daemon (ovs-server)
|
|
will be started.
|
|
'';
|
|
};
|
|
|
|
resetOnStart = mkOption {
|
|
type = types.bool;
|
|
default = false;
|
|
description = ''
|
|
Whether to reset the Open vSwitch configuration database to a default
|
|
configuration on every start of the systemd `ovsdb.service`.
|
|
'';
|
|
};
|
|
|
|
package = mkPackageOption pkgs "openvswitch" { };
|
|
};
|
|
|
|
config = mkIf cfg.enable (
|
|
let
|
|
|
|
# Where the communication sockets live
|
|
runDir = "/run/openvswitch";
|
|
|
|
# The path to the an initialized version of the database
|
|
db = pkgs.stdenv.mkDerivation {
|
|
name = "vswitch.db";
|
|
dontUnpack = true;
|
|
buildPhase = "true";
|
|
buildInputs = [
|
|
cfg.package
|
|
];
|
|
installPhase = "mkdir -p $out";
|
|
};
|
|
|
|
in
|
|
{
|
|
environment.systemPackages = [ cfg.package ];
|
|
boot.kernelModules = [
|
|
"tun"
|
|
"openvswitch"
|
|
];
|
|
|
|
boot.extraModulePackages = [ cfg.package ];
|
|
|
|
systemd.services.ovsdb = {
|
|
description = "Open_vSwitch Database Server";
|
|
wantedBy = [ "multi-user.target" ];
|
|
path = [ cfg.package ];
|
|
restartTriggers = [
|
|
db
|
|
cfg.package
|
|
];
|
|
# Create the config database
|
|
preStart = ''
|
|
mkdir -p ${runDir}
|
|
mkdir -p /var/db/openvswitch
|
|
chmod +w /var/db/openvswitch
|
|
${optionalString cfg.resetOnStart "rm -f /var/db/openvswitch/conf.db"}
|
|
if [[ ! -e /var/db/openvswitch/conf.db ]]; then
|
|
${cfg.package}/bin/ovsdb-tool create \
|
|
"/var/db/openvswitch/conf.db" \
|
|
"${cfg.package}/share/openvswitch/vswitch.ovsschema"
|
|
fi
|
|
chmod -R +w /var/db/openvswitch
|
|
if ${cfg.package}/bin/ovsdb-tool needs-conversion /var/db/openvswitch/conf.db | grep -q "yes"
|
|
then
|
|
echo "Performing database upgrade"
|
|
${cfg.package}/bin/ovsdb-tool convert /var/db/openvswitch/conf.db
|
|
else
|
|
echo "Database already up to date"
|
|
fi
|
|
'';
|
|
serviceConfig = {
|
|
ExecStart = ''
|
|
${cfg.package}/bin/ovsdb-server \
|
|
--remote=punix:${runDir}/db.sock \
|
|
--private-key=db:Open_vSwitch,SSL,private_key \
|
|
--certificate=db:Open_vSwitch,SSL,certificate \
|
|
--bootstrap-ca-cert=db:Open_vSwitch,SSL,ca_cert \
|
|
--unixctl=ovsdb.ctl.sock \
|
|
--pidfile=/run/openvswitch/ovsdb.pid \
|
|
--detach \
|
|
/var/db/openvswitch/conf.db
|
|
'';
|
|
Restart = "always";
|
|
RestartSec = 3;
|
|
PIDFile = "/run/openvswitch/ovsdb.pid";
|
|
# Use service type 'forking' to correctly determine when ovsdb-server is ready.
|
|
Type = "forking";
|
|
};
|
|
postStart = ''
|
|
${cfg.package}/bin/ovs-vsctl --timeout 3 --retry --no-wait init
|
|
'';
|
|
};
|
|
|
|
systemd.services.ovs-vswitchd = {
|
|
description = "Open_vSwitch Daemon";
|
|
wantedBy = [ "multi-user.target" ];
|
|
bindsTo = [ "ovsdb.service" ];
|
|
after = [ "ovsdb.service" ];
|
|
path = [ cfg.package ];
|
|
serviceConfig = {
|
|
ExecStart = ''
|
|
${cfg.package}/bin/ovs-vswitchd \
|
|
--pidfile=/run/openvswitch/ovs-vswitchd.pid \
|
|
--detach
|
|
'';
|
|
PIDFile = "/run/openvswitch/ovs-vswitchd.pid";
|
|
# Use service type 'forking' to correctly determine when vswitchd is ready.
|
|
Type = "forking";
|
|
Restart = "always";
|
|
RestartSec = 3;
|
|
};
|
|
};
|
|
|
|
}
|
|
);
|
|
|
|
imports = [
|
|
(mkRemovedOptionModule [ "virtualisation" "vswitch" "ipsec" ] ''
|
|
OpenVSwitch IPSec functionality has been removed, because it depended on racoon,
|
|
which was removed from nixpkgs, because it was abanoded upstream.
|
|
'')
|
|
];
|
|
|
|
meta.maintainers = with maintainers; [ netixx ];
|
|
|
|
}
|